Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quit properly in simpleFullScreen mode #14620

Merged
merged 1 commit into from Sep 17, 2018
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Sep 13, 2018

Description of Change

Fixes #13135.

Since borderless windows or windows without titlebars doen't have a close button, performClose: won't work. Therefore, we instead want to use the close method. However, this method doesn't call windowShouldClose: on the window's delegate so we manually must call it.

/cc @sethlu

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: fixes issue with app.quit() in simpleFullScreen mode

@alexeykuzmin
Copy link
Contributor

@codebytere Can you please rebase onto the latest master? All these failed CI jobs were caused by a broken master =/

@release-clerk
Copy link

release-clerk bot commented Sep 17, 2018

Release Notes Persisted

fixes issue with app.quit() in simpleFullScreen mode

@trop
Copy link
Contributor

trop bot commented Sep 17, 2018

We have automatically backported this PR to "3-0-x", please check out #14646

@MarshallOfSound
Copy link
Member

/trop run backport-to 2-0-x

@trop
Copy link
Contributor

trop bot commented Sep 19, 2018

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "2-0-x" here we go! :D

@MarshallOfSound
Copy link
Member

@codebytere
Copy link
Member Author

codebytere commented Sep 19, 2018

@MarshallOfSound i put up a manual yesterday, it was linked above :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't app.quit() or CMD+Q when using simple full screen on MacOS
4 participants