New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simpleFullscreen window should be on top of other OS X menu bars. #15183

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@lynaghk
Contributor

lynaghk commented Oct 16, 2018

If an app has no menu bar (because app.dock.hide() has been called),
OS X will still render the menu bar of the previously-focused app.

This commit ensures simpleFullscreen windows will be drawn on top of
that menu bar by setting their level to NSPopUpMenuWindowLevel while
simpleFullscreen mode is active.

Ref: #11468

Backport requested by @codebytere: #14881 (comment)

  • PR description included and stakeholders cc'd
  • PR title follows semantic commit guidelines

Release Notes

Notes: Fixed simpleFullscreen windows in hidden-dock apps from being drawn below OS X menu bar of previously-focused app.

fix: simpleFullscreen window should be on top of other OS X menu bars.
If an app has no menu bar (because `app.dock.hide()` has been called),
OS X will still render the menu bar of the previously-focused app.

This commit ensures simpleFullscreen windows will be drawn on top of
that menu bar by setting their level to NSPopUpMenuWindowLevel while
simpleFullscreen mode is active.

Ref: #11468

@lynaghk lynaghk requested a review from electron/reviewers as a code owner Oct 16, 2018

@MarshallOfSound MarshallOfSound merged commit 7283b78 into electron:3-0-x Oct 16, 2018

12 of 14 checks passed

appveyor: win-x64-testing-pr AppVeyor build failed
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 16, 2018

Release Notes Persisted

Fixed simpleFullscreen windows in hidden-dock apps from being drawn below OS X menu bar of previously-focused app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment