fix: ability to fetch separators by id #15290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykuzmin
approved these changes
Oct 19, 2018
|
Failed on unrelated |
|
Release Notes Persisted
|
This was referenced Oct 19, 2018
|
We have automatically backported this PR to "4-0-x", please check out #15294 |
|
We have automatically backported this PR to "3-0-x", please check out #15295 |
4 tasks
| @@ -156,14 +161,15 @@ function sortGroups (groups) { | |||
|
|
|||
| function sortMenuItems (menuItems) { | |||
| const isSeparator = (item) => item.type === 'separator' | |||
| const separators = menuItems.filter(i => i.type === 'separator') | |||
There was a problem hiding this comment.
const separators = menuItems.filter(isSeparator)| joined.push(joiner) | ||
| if (joinIDs.length > 0) { | ||
| joined.push(joinIDs[0]) | ||
| joinIDs.splice(0, 1) |
There was a problem hiding this comment.
joined.push(joinIDs.shift())Instead of those two lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #15119.
Changes menu-utils to take into account
separators withids such that they are not removed during the sorting process. Also adds a test to prevent future regression./cc @alexeykuzmin
Checklist
npm testpassesRelease Notes
Notes: fixes ability to fetch separators menu items by id