chore: backport printing changes (#15023, #15143) to 4-0-x #15976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any dyld errors in the CI output. Windows looks like it's failing on a compile-time link error, but mac and linux are failing with segfaults that don't look related to dynamic linking to me. The windows link error looks related to 5ef5d60f77 |
* remove printing related things from chromium_src * chore: add printing build flag and patch * fix: include PrintingService on other platforms too * fix: printing_handler is only needed on Windows * fix: format BUILD.gn properly * fix: rename printing build flag to avoid conflict with chromium * fix: place previously missed printing calls behind build flag * fix: accidentally renamed flag in patch file * fix: don't include all printing strings * fix: allow ShowItemInFolder and OpenItem to block, fixing a DCHECK crash * fix: make things compile, some changes got lost while rebasing * fix: remove rogue line from BUILD.gn * chore: update patch description * style: lint fix * chore: use chromium printing buildflag, move node related stuff out of patch * revert: remove ScopedAllowBlockingForTesting call * fix: fix my rebase blooper * fix: re-add header lost during rebase, update patch * fix: add <map> include, tweak the patch a bit * revert: remove rogue diff from patch * fix: clean up after rebase
* refactor: basic printing * move build files to chromium_src/BUILD.gn * remove dependency on chrome prerender sources * spec: move printing specs behind feature flag * build: register pdf compositor service
deepak1556
force-pushed
the
bengotow/4-0-x+printing
branch
2 times, most recently
from
338ccc9
to
7f57e31
Compare
deepak1556
force-pushed
the
bengotow/4-0-x+printing
branch
from
7f57e31
to
b711d0f
Compare
codebytere
approved these changes
Dec 17, 2018
ckerr
approved these changes
Dec 17, 2018
|
Release Notes Persisted
|
This was referenced Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR backports #15023, #15143 to the 4-0-x branch
TODO: I've fixed conflicts in all of the relevant files and tried to update the BUILD.gn files, but I'm experiencing a problem where everything builds and then crashes at runtime with a dyld error. I'm hoping one of the PR authors might be able to spot the build config error—my Chromium-build-foo is weak!
CC @deepak1556 @brenca
Checklist
npm testpassesRelease Notes
Notes: The goal here is to release the fixes for these bugs in 4-0-x.: