New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "ci: use config version 2.1 on CircleCI" #16304

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

codebytere commented Jan 7, 2019

Description of Change

Revert #15665. It's causing broken builds on master.

cc @alexeykuzmin @MarshallOfSound

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from electron/reviewers as a code owner Jan 7, 2019

@MarshallOfSound
Copy link
Member

MarshallOfSound left a comment

Assuming builds are 🍏

@codebytere codebytere changed the title Revert "ci: use config version 2.1 on CircleCI (#15665)" chore: revert "ci: use config version 2.1 on CircleCI" Jan 7, 2019

@codebytere codebytere merged commit 9c7f6af into master Jan 7, 2019

19 of 20 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jan 7, 2019

No Release Notes

@codebytere codebytere deleted the revert-circleci-2.1 branch Jan 7, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment