-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: register accelerator if role has no registerAccelerator #16309
Conversation
Release Notes Persisted
|
I have automatically backported this PR to "4-0-x", please check out #16314 |
…n#16309) * fix: register accelerator if role has no registerAccelerator * ensure roles[role].registerAccelerator is defined
/trop run backport-to 3-1-x |
The backport process for this PR has been manually initiated, |
I have automatically backported this PR to "3-1-x", please check out #16598 |
Description of Change
Resolves #16303.
Previously,
registerAccelerator
defaulted totrue
only if there was no role for the menu item. If there is a role set, it instead used theregisterAccelerator
property for that role; however many of the roles had anundefined
registerAccelerator
.This therefore changes behavior such that a
MenuItem
will only be set toroles[role].registerAccelerator
if it has a role AND that role has a definedregisterAccelerator
property./cc @brenca
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue whereby
registerAccelerator
was being set to theregisterAccelerator
property of its role even whenregisterAccelerator
wasundefined
.