Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ServiceWorker APIs from WebContents #16717

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Conversation

codebytere
Copy link
Member

Description of Change

Refs #16704.

Remove ServiceWorker APIs (hasServiceWorker and unregisterServiceWorker) from WebContents. They haven't worked properly in some time and were not originally intended to exist on WebContents.

cc @deepak1556 @ckerr

Checklist

Release Notes

Notes: Removed hasServiceWorker and unregisterServiceWorker APIs from the WebContents modules.

@ckerr
Copy link
Member

ckerr commented Feb 4, 2019

If the code was broken and nobody complained, IMO that says a lot for getting rid of this API.

However we should get public comment from the project long-timers before pulling the trigger

@deepak1556
Copy link
Member

Originally the api were added to serve the purpose requested in #1331 (comment) , but as time progressed inspecting sw has become more friendly in devtools, I believe this api no longer holds a tight cause to be in the core. Make sure to run a deprecation cycle PR in 5.x before merging this PR.

@codebytere codebytere merged commit f303caa into master Feb 5, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 5, 2019

Release Notes Persisted

Removed hasServiceWorker and unregisterServiceWorker APIs from the WebContents modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants