Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ServiceWorker APIs from WebContents #16717

Merged
merged 1 commit into from Feb 5, 2019

Conversation

@codebytere
Copy link
Member

commented Feb 4, 2019

Description of Change

Refs #16704.

Remove ServiceWorker APIs (hasServiceWorker and unregisterServiceWorker) from WebContents. They haven't worked properly in some time and were not originally intended to exist on WebContents.

cc @deepak1556 @ckerr

Checklist

Release Notes

Notes: Removed hasServiceWorker and unregisterServiceWorker APIs from the WebContents modules.

@miniak

miniak approved these changes Feb 4, 2019

@ckerr

ckerr approved these changes Feb 4, 2019

@ckerr

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

If the code was broken and nobody complained, IMO that says a lot for getting rid of this API.

However we should get public comment from the project long-timers before pulling the trigger

@codebytere codebytere force-pushed the remove-sw branch from 0114ae6 to 5b5f545 Feb 4, 2019

@deepak1556

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

Originally the api were added to serve the purpose requested in #1331 (comment) , but as time progressed inspecting sw has become more friendly in devtools, I believe this api no longer holds a tight cause to be in the core. Make sure to run a deprecation cycle PR in 5.x before merging this PR.

@codebytere codebytere referenced this pull request Feb 5, 2019

Merged

refactor: deprecate ServiceWorker APIs #16732

5 of 5 tasks complete

@codebytere codebytere merged commit f303caa into master Feb 5, 2019

12 of 16 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
appveyor: win-x64-testing AppVeyor build failed
Details
electron-arm-testing Build #20190204.18 has failed
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190204.20 succeeded
Details
electron-lint Build #20190204.22 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 5, 2019

Release Notes Persisted

Removed hasServiceWorker and unregisterServiceWorker APIs from the WebContents modules.

@codebytere codebytere deleted the remove-sw branch Feb 12, 2019

@codebytere codebytere referenced this pull request Feb 14, 2019

Closed

refactor: remove ServiceWorker APIs from WebContents #16968

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.