Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure dots in content script patterns aren't used as wildcards #17594

Merged
merged 4 commits into from Mar 28, 2019

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

commented Mar 28, 2019

Backport of #17593

Notes: Injected chrome extensions that have content scripts with a . in the pattern field now treat it as a raw . instead of a wildcard

MarshallOfSound added some commits Mar 28, 2019

@MarshallOfSound MarshallOfSound merged commit d5bb0e9 into 5-0-x Mar 28, 2019

12 of 17 checks passed

electron-arm-testing Build #20190328.12 failed
Details
appveyor: win-ia32-debug Waiting for AppVeyor build to complete
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-debug Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Backportable? - 2-0-x Clean Backport
Details
Backportable? - 3-1-x Clean Backport
Details
Backportable? - 4-1-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190328.12 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 28, 2019

Release Notes Persisted

Injected chrome extensions that have content scripts with a . in the pattern field now treat it as a raw . instead of a wildcard

@MarshallOfSound MarshallOfSound deleted the MarshallOfSound-patch-2 branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.