Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report module name when require fails in sandboxed renderers #17704

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@miniak
Copy link
Contributor

commented Apr 5, 2019

Description of Change

Backport #17413

Added missing module name to the exception message thrown when require fails in sandboxed renderers. Follow up to chore: remove deprecated modules internally using remote.require in sandboxed renderer context

Checklist

Release Notes

Notes: Added missing module name to the exception message thrown when require fails in sandboxed renderers.

/cc @electron/wg-releases

@miniak miniak requested a review from electron/wg-releases Apr 5, 2019

@codebytere codebytere changed the title fix: report module name when require fails in sandboxed renderers (backport: 4-1-x) fix: report module name when require fails in sandboxed renderers Apr 5, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Apr 5, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@codebytere can you please check this one as well?

@codebytere codebytere merged commit 46a1ce8 into 4-1-x Apr 10, 2019

14 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190405.7 succeeded
Details
electron-arm64-testing Build #20190405.7 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 10, 2019

Release Notes Persisted

Added missing module name to the exception message thrown when require fails in sandboxed renderers.

@codebytere codebytere deleted the miniak/sandbox-require-error-4-1-x branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.