-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure the inspector agent is shutdown before cleaning up the node env #18028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Legitimate failures on windows it looks like 😢 |
875ccd0
to
cacebb0
Compare
Release Notes Persisted
|
I have automatically backported this PR to "5-0-x", please check out #18076 |
I have automatically backported this PR to "6-0-x", please check out #18077 |
…de env (electron#18028) * fix: ensure the inspector agent is shutdown before cleaning up the node env * spec: add tests to ensure clean shutdown with connected inspector agent * Update node_debugger.cc
Fixes #17996
Notes: Fixed crash when quitting Electron with an inspector attached