Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting of global fallback user agent #18110

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
3 participants
@MarshallOfSound
Copy link
Member

commented May 2, 2019

Backport of #18016

See that PR for details. Approved for 4.2.0 backport by @electron/wg-releases on 01/05/19

Notes: Added new app.userAgentFallback property to allow setting the apps useragent globally

@MarshallOfSound MarshallOfSound force-pushed the global-ua-4 branch from c5a07d8 to 0edf4e0 May 2, 2019

@MarshallOfSound MarshallOfSound force-pushed the global-ua-4 branch from 0edf4e0 to 4d85db3 May 2, 2019

@MarshallOfSound MarshallOfSound marked this pull request as ready for review May 2, 2019

@MarshallOfSound MarshallOfSound requested a review from deepak1556 May 2, 2019

@MarshallOfSound MarshallOfSound force-pushed the global-ua-4 branch from 4d85db3 to 512e920 May 2, 2019

@MarshallOfSound MarshallOfSound force-pushed the global-ua-4 branch from 512e920 to 51d7744 May 2, 2019

@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

This is slightly different to the master PR as we have to send the user-agent over the process arguments in order to support the override for service workers. In 4-0-x the service worker UA is initialized in the renderer. In master it is initialized in the browser process so we don't have this work around.

@MarshallOfSound MarshallOfSound merged commit 9a665eb into 4-2-x May 2, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190502.9 succeeded
Details
electron-arm64-testing Build #20190502.9 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 2, 2019

Release Notes Persisted

Added new app.userAgentFallback property to allow setting the apps useragent globally

@MarshallOfSound MarshallOfSound deleted the global-ua-4 branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.