-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump libcc (3-1-x) #18426
chore: bump libcc (3-1-x) #18426
Conversation
@jkleinsc pointed out that there are known CI issues in 3-1-x and so @MarshallOfSound suggested using #18283 as a baseline since it's a recent 3-1-x PR that just bumps a package.json dependency. And However
The two failing tests are:
|
those two failures used to happen a lot on that branch iirc 🤔 |
To partially rule out flakes: I re-ran both |
Windows CI is now passing; Linux CI the test are passing but it times out trying to shutdown dbusmock, so I think this PR can be merged as is. |
No Release Notes |
Fixes #18420
Updating libcc reference to latest. Changes since the last roll:
d84bd5a5
fix: include v8 flags used by electronmksnapshot comes from the ffmpeg build and needs the same v8 flags used for the static library build
55625e1d
Merge pull request fix: include v8 flags used by electron in ffmpeg build libchromiumcontent#760 from electron/fix-mksnapshot-v8-flagsfix: include v8 flags used by electron in mksnapshot build
Notes: no-notes