-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't call SetBounds on restore #19886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There is conflict needs to be resolved. |
9f50ea1
to
eb31741
Compare
@zcbenz I resolved the conflict! |
Release Notes Persisted
|
I have automatically backported this PR to "6-0-x", please check out #19956 |
I have automatically backported this PR to "7-0-x", please check out #19957 |
Description of Change
This is a revert of #8047, the issues mentioned there are not reproducible after the revert (in fact #7951 resurfaced, and this fixes that). Since the issue mentioned in the comments (#2498) is about frameless window sizing and the PR I created to improve that landed in
6-0-x
, I'm only backporting until that to make sure not to re-introduce the original bug.Fixes #13043.
Fixes #16900.
Checklist
npm test
passesRelease Notes
Notes: Fix a bug where an unresizable window would shrink when restored after being minimized on Windows.