test: ensure cleanup of net requests in tests #20510

nornagon · 2019-10-09T23:06:53Z

I'm reviving this because these tests are still flaking out on Windows, so it's not related to #19368. cc @deepak1556

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: none

release-clerk · 2019-10-10T12:14:45Z

No Release Notes

nornagon · 2019-10-21T18:25:30Z

/trop run backport-to 7-0-x

trop · 2019-10-21T18:25:32Z

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "7-0-x" here we go! :D

trop · 2019-10-21T18:26:04Z

I have automatically backported this PR to "7-0-x", please check out #20663

test: ensure cleanup of net requests in tests

def51b2

ref #19389

deepak1556 approved these changes Oct 9, 2019

View reviewed changes

codebytere approved these changes Oct 10, 2019

View reviewed changes

codebytere merged commit 1dc1ef6 into master Oct 10, 2019

codebytere deleted the net-test-cleanup branch October 10, 2019 12:14

trop bot mentioned this pull request Oct 21, 2019

test: ensure cleanup of net requests in tests #20663

Closed

trop bot added the in-flight/7-0-x label Oct 21, 2019

Provide feedback