Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure cleanup of net requests in tests #20510

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@nornagon
Copy link
Member

commented Oct 9, 2019

Description of Change

I'm reviving this because these tests are still flaking out on Windows, so it's not related to #19368. cc @deepak1556

Ref #19389

Checklist

Release Notes

Notes: none

@codebytere codebytere merged commit 1dc1ef6 into master Oct 10, 2019
15 checks passed
15 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191009.30 succeeded
Details
electron-arm64-testing Build #20191009.31 succeeded
Details
electron-woa-testing Build #20191009.24 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Oct 10, 2019

No Release Notes

@codebytere codebytere deleted the net-test-cleanup branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.