Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save dialog extensions should be deterministic #25192

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 28, 2020

Backport of #25164

See that PR for details.

Notes: Fixed an issue where filters set in dialogs on macOS would have nondeterministic ordering.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 28, 2020
@trop trop bot requested a review from codebytere Aug 28, 2020
@trop trop bot added 10-x-y backport This is a backport PR labels Aug 28, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 28, 2020
@codebytere
Copy link
Member

Failures are non-macOS flakes

@codebytere codebytere merged commit 66b6789 into 10-x-y Aug 28, 2020
6 of 7 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 28, 2020

Release Notes Persisted

Fixed an issue where filters set in dialogs on macOS would have nondeterministic ordering.

@codebytere codebytere deleted the trop/10-x-y-bp-fix-save-dialog-extensions-should-be-deterministic-1598632861711 branch Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant