-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: repl crash when SharedArrayBuffer disabled #30456
Conversation
1eede72
to
51d65a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodejs/node#39718 (review) is a little troubling, if it also applies to Electron.
@ckerr it does - i've tuned it up in both places :) |
51d65a8
to
24fbc24
Compare
24fbc24
to
2906740
Compare
Release Notes Persisted
|
I have automatically backported this PR to "13-x-y", please check out #30482 |
I have automatically backported this PR to "15-x-y", please check out #30483 |
I have automatically backported this PR to "14-x-y", please check out #30484 |
Description of Change
Refs nodejs/node#39717.
Can be reproduced with
e node --no-harmony-sharedarraybuffer
.Fixes an issue where the repl will crash if it's required in the renderer process or invoked as above.
Checklist
npm test
passesRelease Notes
Notes: Fixed a crash in the repl when
SharedArrayBuffer
is disabled.