Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repl crash when SharedArrayBuffers are disabled #39717

Closed
codebytere opened this issue Aug 9, 2021 · 0 comments · Fixed by #41023
Closed

Repl crash when SharedArrayBuffers are disabled #39717

codebytere opened this issue Aug 9, 2021 · 0 comments · Fixed by #41023
Assignees
@codebytere
Labels
confirmed-bug Issues with confirmed bugs. repl Issues and PRs related to the REPL subsystem.

Comments

@codebytere
Copy link
Member

Version

master

Platform

Darwin Shelleys-MBP.fritz.box 20.6.0 Darwin Kernel Version 20.6.0: Wed Jun 23 00:26:31 PDT 2021; root:xnu-7195.141.2~5/RELEASE_X86_64 x86_64

Subsystem

repl

What steps will reproduce the bug?

  1. Run node --no-harmony-sharedarraybuffer
  2. Try to type an arbitrary command
  3. Observe crash:
electron_node on git:a3d0cc7244 ❯ node --no-harmony-sharedarraybuffer       6:25PM
Welcome to Node.js v16.2.0.
Type ".help" for more information.
> snode:internal/readline/emitKeypressEvents:71
            throw err;
            ^

TypeError: SharedArrayBuffer is not a constructor
    at node:internal/worker:96:32
    at NativeModule.compileForInternalLoader (node:internal/bootstrap/loaders:312:7)
    at nativeModuleRequire (node:internal/bootstrap/loaders:341:14)
    at node:worker_threads:11:5
    at NativeModule.compileForInternalLoader (node:internal/bootstrap/loaders:312:7)
    at nativeModuleRequire (node:internal/bootstrap/loaders:341:14)
    at node:inspector:32:26
    at NativeModule.compileForInternalLoader (node:internal/bootstrap/loaders:312:7)
    at nativeModuleRequire (node:internal/bootstrap/loaders:341:14)
    at sendInspectorCommand (node:internal/util/inspector:14:21)

How often does it reproduce? Is there a required condition?

100%

What is the expected behavior?

The repl does not crash.

What do you see instead?

The repl crashes.

Additional information

No response
@codebytere codebytere added the repl Issues and PRs related to the REPL subsystem. label Aug 9, 2021
@codebytere codebytere self-assigned this Aug 9, 2021
This was referenced Aug 9, 2021
Closed
Merged
@tniessen tniessen added the confirmed-bug Issues with confirmed bugs. label Aug 9, 2021
BridgeAR added a commit to BridgeAR/node that referenced this issue Nov 29, 2021
@BridgeAR
lib: do not crash using workers with disabled shared array buffers
cb4adab 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.

Fixes: nodejs#39717

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this issue Nov 29, 2021
Merged
BridgeAR added a commit to BridgeAR/node that referenced this issue Dec 4, 2021
@BridgeAR
lib: do not crash using workers with disabled shared array buffers
f4ae17d 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.

Fixes: nodejs#39717

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit to BridgeAR/node that referenced this issue Dec 4, 2021
@BridgeAR
lib: do not crash using workers with disabled shared array buffers
73059c2 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.

Fixes: nodejs#39717

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit to BridgeAR/node that referenced this issue Dec 4, 2021
@BridgeAR
lib: do not crash using workers with disabled shared array buffers
a39f548 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.

Fixes: nodejs#39717

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit to BridgeAR/node that referenced this issue Dec 8, 2021
@BridgeAR @codebytere
lib: do not crash using workers with disabled shared array buffers
f26a4d0 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.

Fixes: nodejs#39717

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this issue Jul 6, 2022
@BridgeAR @codebytere
lib: do not crash using workers with disabled shared array buffers
afb4279 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.

Fixes: nodejs#39717

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this issue Jul 6, 2022
@BridgeAR @codebytere
lib: do not crash using workers with disabled shared array buffers
d7846e4 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.
It also fixes using workers while using the
`--no-harmony-atomics` V8 flag.

Fixes: nodejs#39717

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this issue Feb 17, 2023
@BridgeAR @codebytere
lib: do not crash using workers with disabled shared array buffers
ed3865f 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.
It also fixes using workers while using the
`--no-harmony-atomics` V8 flag.

Fixes: nodejs#39717

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
aduh95 pushed a commit that referenced this issue Feb 18, 2023
@BridgeAR @codebytere
lib: do not crash using workers with disabled shared array buffers
fbd55a8 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.
It also fixes using workers while using the
`--no-harmony-atomics` V8 flag.

Fixes: #39717

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #41023
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 18, 2023
@BridgeAR @codebytere @MylesBorins
lib: do not crash using workers with disabled shared array buffers
3d2988e 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.
It also fixes using workers while using the
`--no-harmony-atomics` V8 flag.

Fixes: #39717

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #41023
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 20, 2023
@BridgeAR @codebytere @MylesBorins
lib: do not crash using workers with disabled shared array buffers
4aebee6 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.
It also fixes using workers while using the
`--no-harmony-atomics` V8 flag.

Fixes: #39717

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #41023
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this issue Apr 11, 2023
@BridgeAR @codebytere @danielleadams
lib: do not crash using workers with disabled shared array buffers
46a22ab 
This allows the repl to function normally while using the
`--no-harmony-sharedarraybuffer` V8 flag.
It also fixes using workers while using the
`--no-harmony-atomics` V8 flag.

Fixes: #39717

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #41023
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ajklein ajklein mentioned this issue Apr 14, 2023
Merged
ajklein added a commit to v8/node that referenced this issue Apr 14, 2023
@ajklein
Skip test depending on always-true removed --harmony-atomics flag (#155)
d016b39 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
@ajklein ajklein mentioned this issue Apr 14, 2023
Merged
pthier pushed a commit to v8/node that referenced this issue Apr 26, 2023
@ajklein
Skip test depending on always-true removed --harmony-atomics flag (#155)
71075f8 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
victorgomes pushed a commit to v8/node that referenced this issue May 22, 2023
@ajklein @victorgomes
Skip test depending on always-true removed --harmony-atomics flag (#155)
57e6bd0 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
pthier pushed a commit to v8/node that referenced this issue Jul 4, 2023
@ajklein
Skip test depending on always-true removed --harmony-atomics flag (#155)
063f937 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
pthier pushed a commit to v8/node that referenced this issue Aug 24, 2023
@ajklein
Skip test depending on always-true removed --harmony-atomics flag (#155)
21e78c6 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
victorgomes pushed a commit to v8/node that referenced this issue Sep 12, 2023
@ajklein @victorgomes
Skip test depending on always-true removed --harmony-atomics flag (#155)
3d39c00 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
victorgomes pushed a commit to v8/node that referenced this issue Sep 12, 2023
@ajklein @victorgomes
Skip test depending on always-true removed --harmony-atomics flag (#155)
4b134bc 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
victorgomes pushed a commit to v8/node that referenced this issue Nov 8, 2023
@ajklein @victorgomes
Skip test depending on always-true removed --harmony-atomics flag (#155)
41bf67b 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
pthier pushed a commit to v8/node that referenced this issue Jan 17, 2024
@ajklein
Skip test depending on always-true removed --harmony-atomics flag (#155)
38c459a 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
victorgomes pushed a commit to v8/node that referenced this issue Feb 14, 2024
@ajklein @victorgomes
Skip test depending on always-true removed --harmony-atomics flag (#155)
01d5fe8 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
victorgomes pushed a commit to v8/node that referenced this issue Mar 4, 2024
@ajklein @victorgomes
Skip test depending on always-true removed --harmony-atomics flag (#155)
f728ce9 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
pthier pushed a commit to v8/node that referenced this issue Mar 21, 2024
@ajklein
Skip test depending on always-true removed --harmony-atomics flag (#155)
35a0616 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
victorgomes pushed a commit to v8/node that referenced this issue Apr 23, 2024
@ajklein @victorgomes
Skip test depending on always-true removed --harmony-atomics flag (#155)
dae64ec 
The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codebytere codebytere

Labels
confirmed-bug Issues with confirmed bugs. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
2 participants
@codebytere @tniessen