New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle maximize/fullscreen in window without thickFrame #6417

Merged
merged 4 commits into from Jul 9, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Jul 9, 2016

For window without thickFrame, we have to keep them always in normal window state, otherwise weird things will happen.

Close #1690.

@zcbenz zcbenz merged commit c5dd345 into master Jul 9, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3627288 succeeded in 45s
Details
electron-linux-ia32 Build #3627289 succeeded in 43s
Details
electron-linux-x64 Build #3627290 succeeded in 76s
Details
electron-mas-x64 Build #1846 succeeded in 5 min 38 sec
Details
electron-osx-x64 Build #1856 succeeded in 6 min 58 sec
Details
electron-win-ia32 Build #856 succeeded in 6 min 17 sec
Details
electron-win-x64 Build #846 succeeded in 6 min 25 sec
Details

@zcbenz zcbenz deleted the thick-frame-maximze branch Jul 9, 2016

@RobinCodeX

This comment has been minimized.

RobinCodeX commented Dec 9, 2016

Hi, my app run in Windows10, if thickFrame: false then can not be maximize, this is a BUG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment