Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all spaces from potential appUserModelID as it isn't allowed by the spec #6602

Merged
merged 2 commits into from
Jul 27, 2016
Merged

Remove all spaces from potential appUserModelID as it isn't allowed by the spec #6602

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12dba2c
Remove all spaces from potential appUserModelID as it isn't allowed b…
MarshallOfSound Jul 26, 2016
9f0299c
Use better regex to match spaces
MarshallOfSound Jul 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/browser/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ if (process.platform === 'win32') {

if (fs.statSyncNoException(updateDotExe)) {
var packageDir = path.dirname(path.resolve(updateDotExe))
var packageName = path.basename(packageDir)
var exeName = path.basename(process.execPath).replace(/\.exe$/i, '')
var packageName = path.basename(packageDir).replace(/ /g, '')
Copy link
Contributor

@zeke zeke Jul 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe /\s/g would match more space-like characters?

var exeName = path.basename(process.execPath).replace(/\.exe$/i, '').replace(/ /g, '')

app.setAppUserModelId(`com.squirrel.${packageName}.${exeName}`)
}
Expand Down