Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an API to fetch file icon #7851

Merged
merged 32 commits into from
Feb 7, 2017
Merged

Add an API to fetch file icon #7851

merged 32 commits into from
Feb 7, 2017

Commits on Feb 7, 2017

  1. WIP

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    be5b907 View commit details
    Browse the repository at this point in the history

  2. Add callback converters

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    1d24a3a View commit details
    Browse the repository at this point in the history

  3. Add icon fetching sources

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    8e4ed66 View commit details
    Browse the repository at this point in the history

  4. Try my own class

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    d118fed View commit details
    Browse the repository at this point in the history

  5. Get it compiling, linking till fails though

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    eb889b9 View commit details
    Browse the repository at this point in the history

  6. Include proper header

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    602aba8 View commit details
    Browse the repository at this point in the history

  7. Add icon manager to browser process

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    1b3cd87 View commit details
    Browse the repository at this point in the history

  8. create iconmanager as singleton class and cleanup code (#1) 

    * create iconmanager as singleton class and cleanup code
    @deepak1556 @kevinsawicki
    deepak1556 authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    b25b141 View commit details
    Browse the repository at this point in the history

  9. define icon loader for liunx as separate target

    @deepak1556 @kevinsawicki
    deepak1556 authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    ff3aaa5 View commit details
    Browse the repository at this point in the history

  10. Make size optional

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    bec671b View commit details
    Browse the repository at this point in the history

  11. Use object for options

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    05cb26a View commit details
    Browse the repository at this point in the history

  12. Add docs

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    fe99b25 View commit details
    Browse the repository at this point in the history

  13. Fix lint

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    3d47c9b View commit details
    Browse the repository at this point in the history

  14. Fix code style

    @deepak1556 @kevinsawicki
    deepak1556 authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    2e85ff1 View commit details
    Browse the repository at this point in the history

  15. Image from icon node-style callback (#2) 

    * Try implementing node-style callbacks

* Add locker and handle scope
    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    1b4ee6e View commit details
    Browse the repository at this point in the history

  16. Normalize path

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    5794138 View commit details
    Browse the repository at this point in the history

  17. Update docs

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    11ef2c5 View commit details
    Browse the repository at this point in the history

  18. Put locker and handle scope to the top of the function. Remove unneed… 

    …ed header
    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    c2bf5bb View commit details
    Browse the repository at this point in the history

  19. Add tests

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    0074888 View commit details
    Browse the repository at this point in the history

  20. Lint tests

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    1aa4fca View commit details
    Browse the repository at this point in the history

  21. Properly skip large size test on macOS

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    c36cdb8 View commit details
    Browse the repository at this point in the history

  22. Use isolate() method to get isolate

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    2945236 View commit details
    Browse the repository at this point in the history

  23. Fix some feedback

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    2b60df3 View commit details
    Browse the repository at this point in the history

  24. Fix more review

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    bcf0964 View commit details
    Browse the repository at this point in the history

  25. Fix doc lint

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    c810e64 View commit details
    Browse the repository at this point in the history

  26. Fix large icon spec

    @YurySolovyov @kevinsawicki
    YurySolovyov authored and kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    a9dae24 View commit details
    Browse the repository at this point in the history

  27. Update IconManager for Chrome 56 upgrade

    @kevinsawicki
    kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    ee66776 View commit details
    Browse the repository at this point in the history

  28. Call done instead of skip

    @kevinsawicki
    kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    683a758 View commit details
    Browse the repository at this point in the history

  29. Tweak spec descriptions

    @kevinsawicki
    kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    dddc6ae View commit details
    Browse the repository at this point in the history

  30. Document sizes

    @kevinsawicki
    kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    a4277bb View commit details
    Browse the repository at this point in the history

  31. Tweak optional syntax

    @kevinsawicki
    kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    fc1b743 View commit details
    Browse the repository at this point in the history

  32. Large is only 48x48 on Linux

    @kevinsawicki
    kevinsawicki committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    82ac4dd View commit details
    Browse the repository at this point in the history