Redo node 7.4 error handling patch #8507
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request redoes the patch we apply to node to configure error handling for things like
uncaughtException
events.When I upgraded to Node 7.4.0 in #8406 the patch was ported forward but the diff lines were moved to a new function that isn't called by either
LoadEnvironment
orCreateEnvironment
so they weren't getting properly set.Node 6.5.0 patch: electron/node@f098774
Original Node 7.4.0 patch: electron/node@f1e3c10
New Node 7.4.0 patch: electron/node@8416f53
The diff of the old patch vs the new patch is:
Closes #8499