-
Notifications
You must be signed in to change notification settings - Fork 651
feat: use cmark-gfm for rendering blog posts #2160
Conversation
Okay, I believe this is feature-complete when compared with the previous renderer. I still want to do some comparisons of the old and new results to make sure nothing unexpected broke. |
@electron/wg-website This is ready for review. I downloaded a copy of every blog post on the current site and on this PR's deployment, and generated a diff for each. The results show that the changes are either (1) whitespace changes (particularly an extra non-visible newline at the end of code blocks), (2) single/double quote changes, (3) some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blog posts are now loaded dynamically
Per #2102, this PR updates the site to use cmark-gfm (via BinaryMuse/electron-markdown) instead of hubdown for rendering blog posts (this is the only markdown rendering done directly by the site). The PR also makes a few other refactoring-style changes to the blog route handlers.
blog
middleware and replaces it with actual routes that use a newblog
lib for finding and parsing blog postsblog
libviews/posts
toviews/blog
Todo:
/blog/2015-whats-new-in-electron
)