Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Me -> Shell Demo not working #1490

Closed
SpoonOfDoom opened this issue Oct 26, 2023 · 2 comments · Fixed by #1491
Closed

Show Me -> Shell Demo not working #1490

SpoonOfDoom opened this issue Oct 26, 2023 · 2 comments · Fixed by #1491
Assignees
Labels
area:show-me 🪲 bug Something isn't working

Comments

@SpoonOfDoom
Copy link

Hi,
I'm new to Electron and just discovered the fiddle. I was messing around with the "Show Me" examples a bit, and I noticed that the Shell example does not work. It appears that the const { shell } = require('electron') in preload.js does not work, as shell stays undefined:

[54160:1026/192215.651:INFO:CONSOLE(6)] "Uncaught TypeError: Cannot read properties of undefined (reading 'openExternal')", source: file:///C:/Users/chris/AppData/Local/Temp/electron-fiddle-2100-702yucriB41o/index.html (6)

I've tried this with the latest minor versions of Electron 25, 26 and 27, and all had the same behaviour.

Now as I said, I'm new to this, so I'm not 100% sure if this is a broken example, or if it actually should work as is and there is some other problem.

@codebytere
Copy link
Member

hey @SpoonOfDoom - this happened as a result of a sandbox default change in Electron 20. I've opened a PR to fix it.

@codebytere codebytere added 🪲 bug Something isn't working area:show-me labels Oct 26, 2023
@codebytere codebytere self-assigned this Oct 26, 2023
@SpoonOfDoom
Copy link
Author

Got it, thanks for the reply (and the fix, of course)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:show-me 🪲 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants