Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

husky precommit hook is not executed #588

Closed
ckerr opened this issue Mar 3, 2021 · 0 comments · Fixed by #589
Closed

husky precommit hook is not executed #588

ckerr opened this issue Mar 3, 2021 · 0 comments · Fixed by #589
Assignees
@ckerr
Labels
🪲 bug Something isn't working

Comments

@ckerr
Copy link
Member

ckerr commented Mar 3, 2021 •
edited
Loading

running git commit when working on fiddle gives this warning:

$ git commit ...
hint: The '.husky/pre-commit' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.

Looks like this is a recent change introduced a couple of days ago in #583
@ckerr ckerr self-assigned this Mar 3, 2021
@ckerr ckerr mentioned this issue Mar 3, 2021
Merged
@ckerr ckerr added the 🪲 bug Something isn't working label Mar 3, 2021
@ckerr ckerr closed this as completed in #589 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckerr ckerr

Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: make husky precommit hook executable electron/fiddle
1 participant
@ckerr