build(webpack): remove webpack definePlugin pointing to static folder #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 5e99d72 into 5632814 - view on LGTM.com new alerts:
|
aryanshridhar
force-pushed
the
Fix-CIPathIssue
branch
from
5e99d72
to
4290c8f
Compare
VerteDinde
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversations - https://electronhq.slack.com/archives/C03G7RWF6KH/p1658190886702879.
Basically, for some reason (to debug later) github action production release incorrectly computes
STATIC_DIRglobal variable defined in webpack plugins.