New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove dead code #1144

Merged

BlackHole1 merged 1 commit into electron:main from aryanshridhar:Remove-UnsedVar

Aug 4, 2022

Collaborator

aryanshridhar commented Aug 3, 2022 •

edited

Loading

A minor commit which -

Removes unused path variable in setup.js (had to be removed in build(webpack): remove webpack definePlugin pointing to static folder #1138)
Deduplicates the resolveJsonModule in tsconfig (was introduced by feat: add Intellisense for Node.js #988 as well)


          refactor: remove dead code

8e6c3c7

* Removes unused `path` variable in setup.js
* Deduplicates the `resolveJsonModule` in tsconfig

coveralls commented Aug 3, 2022

Coverage remained the same at 92.508% when pulling 8e6c3c7 on aryanshridhar:Remove-UnsedVar into 440a94b on electron:main.

codebytere approved these changes

View reviewed changes

erickzhao approved these changes

View reviewed changes

BlackHole1 approved these changes

View reviewed changes

BlackHole1 merged commit d77d3ac into electron:main

aryanshridhar deleted the Remove-UnsedVar branch

August 6, 2022 16:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet