Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot produce a working windows binary from template project with no changes #3607

Open
3 tasks done
ofersadgat opened this issue May 23, 2024 · 4 comments
Open
3 tasks done

Comments

@ofersadgat
Copy link

ofersadgat commented May 23, 2024

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.4.0

Electron version

30.0.7

Operating system

Windows 10 (Version 10.0.19045 Build 19045)

Last known working Electron Forge version

No response

Expected behavior

Electron binary to run

Actual behavior

Electron binary doesnt run and instead produces the error (when run from a command line):

[293384:0523/095224.285:FATAL:archive_win.cc(152)] Failed to find file integrity info for resources\app.asar
[293384:0523/095224.285:ERROR:crashpad_client_win.cc(868)] not connected

Steps to reproduce

I use WSL for an Ubuntu 20.04 command line, but it shouldnt make a difference (since I build in a docker container):

  1. npm init electron-app@latest my-app -- --template=webpack-typescript
  2. cd my-app
  3. docker run -it -v ${HOME}:${HOME} -v /etc/passwd:/etc/passwd -u id -u:id -g -v ${PWD}:/repo electronuserland/builder:wine-mono /bin/bash
  4. cd /repo
  5. yarn install
  6. yarn run package --platform win32 (this succeeds without error)

To see error:
7. In windows, open file explorer to the 'out' directory
8. Double click electron-typescript.exe (nothing happens)
9. Open the same directory in powershell
10. ./electron-typescript.exe
11. Observe error

Additional information

Note: when I use a native environment (e.g. powershell + windows node) the same steps above do work. They just dont work while running the docker image (which is what I would like to use for CI). I have also tried running the docker image from powershell and it produces the same result.

@gorillamoe
Copy link

I had the same issue, so I'm also keen on fixing it. A workaround is to disable validation like here https://github.com/mistweaverco/timetrack/blob/main/forge.config.ts#L68

@rap2hpoutre
Copy link

Thank you, I just ran into the same issue @gorillamoe fixed it.

@ofersadgat
Copy link
Author

FYI for everyone watching this, there is a PR to fix it here: electron-userland/electron-builder#8245

@spencerwilson
Copy link

I also observed this bug under:

├── @electron-forge/cli@7.4.0
├── @electron-forge/maker-zip@7.4.0
├── @electron-forge/plugin-auto-unpack-natives@7.4.0
├── @electron-forge/plugin-fuses@7.4.0
└── electron@31.2.0

and also had success with the "disable the fuse" workaround:

[FuseV1Options.EnableEmbeddedAsarIntegrityValidation]: false,

For reference, the tutorial doc on ASAR integrity says electron@30 and above ought to work: https://www.electronjs.org/docs/latest/tutorial/asar-integrity


FYI for everyone watching this, there is a PR to fix it here: electron-userland/electron-builder#8245

That PR is to electron-builder and so would not fix this issue. That project and Forge are independent:

Electron Forge can be considered an alternative to Electron Builder, which fulfills the same use-case for application building and publishing.

See https://electronforge.io/core-concepts/why-electron-forge#forge-vs.-builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants