feat(publisher): Allow to configure channel for ERS #456
Conversation
|
@gossi Could you make this PR target the |
|
@MarshallOfSound just changed to PS I must admit, I only used github UI to do this PR 😉 😇 |
|
@gossi here are our guidelines for submitting pull requests: https://github.com/electron-userland/electron-forge/blob/master/CONTRIBUTING.md#filing-pull-requests At the moment we're asking contributors who are submitting pull requests to point to the |
|
ok I did. Anything else I can do? |
|
Hmmm. GitHub seems to think it's not mergeable. I think you need to do a rebase+squash. When you squash, could you reword the commit so that it follows the correct format? This is so the change gets recorded in our changelog. @MarshallOfSound kind of difficult to see whether the tests pass given that |
|
I rebased with |
|
We usually "Rebase and merge", and this is the error we're seeing in GitHub:
|
|
Anyway, the advantage of you doing the squashing is so you can adjust the commit message as well, per my earlier comment. |
|
ok. took me a while to figure out. But now should be one commit and the correct commit message (if I derived the scope correctly from other commit messages). |
malept
changed the title
|
LGTM |
|
Hmmm. I just realized that this config option is not documented. |
Backport of #456 to 5.x, with docs + minor code refactor.
Backport of #456 to 5.x, with docs + minor code refactor.
* temp * Start working in new package structure * Example maker * All makers implemented and tests passing on darwin * Add v6 branches to travis config * Add v6 branches to appveyor config * Gitignore _old * Remove FIXME comments * Remove from CI branch whitelist * Install bolt on docker * Add to whitelist * Fix bolt usage on CI * Run bolt build on CI * Fix tests on CI * Fix linting * Fix CI * Make publishers work and add specs * Docs template * Initial docs * update plugin interface to support resolving strings * more docs * add deps and scripts * send makeResults instead of flatten artifacts list * feat(publisher): Allow to configure channel for ERS (#456) * fix(publisher): call resolve() when electron-release-server publisher succeeds (#465) ISSUES CLOSED: #460 * Fix publisher tests * Remove stray console statement * v6-api is a PR now, no need to explicitly add to CI * Add top level license * Change Maker/Publisher syntax so that they can be constructed with a config variable * Fix custom init * Allow absolute paths to custom modules * Update to new @electron-forge/ scope * Add missing semi * Use absolute path for custom init to avoid runnig npm link on windows * Fix appx test reference to fixture key file * Remove shell completion support (#447) tabtab is rather buggy and the alternative, commander-completion, needs a custom completion script to be written and maintained. * install new beta tagged bolt on CI * Fix testing snap building in Travis * fix remove error * Fix config passing in tests * fix search order
pr for #455