This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
chore: Chromium 67 #607
Merged
chore: Chromium 67 #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykuzmin
commented
Jul 21, 2018
| file: string_piece_check_disable.patch | ||
| description: | | ||
| Disables some static checks on constexpr's in the string_piece helper to | ||
| avoid incompatibilities with node's CHECK macro |
There was a problem hiding this comment.
@MarshallOfSound
Please preserve newlines at the end of files.
alexeykuzmin
commented
Jul 21, 2018
|
|
||
| constexpr void remove_suffix(size_type n) { | ||
| - CHECK(n <= length_); | ||
| + // CHECK(n <= length_); |
There was a problem hiding this comment.
There was a problem hiding this comment.
The patch is not needed, the fix is on electron side.
There was a problem hiding this comment.
Heh, heavy-handed approach 😆
|
@MarshallOfSound @deepak1556 |
chromiumcontent/build_libs.py
Outdated
| @@ -143,11 +143,12 @@ def gen_list(out, name, obj_dirs, exclude_dirs=[]): | |||
| out, | |||
| "obj_components", | |||
| [ | |||
| "components/appdu", | |||
There was a problem hiding this comment.
Oh my.... I spent like a solid hour this afternoon wondering why this didn't work.... 😢
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
from
c6d1423
to
eef3a60
Compare
nornagon
reviewed
Jul 30, 2018
| # As of Chromium 67.0.3396.99 widevine is only supported on Mac and Windows. | ||
| if (target_os != "linux") { | ||
| enable_widevine = true | ||
| } |
There was a problem hiding this comment.
This seems like a bummer; is upstream no longer supporting this?
There was a problem hiding this comment.
We don't have the chrome component updater setup in electron, also for proprietary reasons we ask users to get their own widevine libraries, electron only integrates mechanism required to load cdm. So this build flag will not affect us directly.
There was a problem hiding this comment.
@nornagon It is not supported on Linux in Ch67. I have no idea if there are plans to support it in the future.
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
3 times, most recently
from
e349f85
to
a0064a6
Compare
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
from
a0064a6
to
4b0a023
Compare
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
from
1fff3a0
to
724a397
Compare
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
2 times, most recently
from
8e8093f
to
55ed064
Compare
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
from
47cbae5
to
e4e0146
Compare
Trivial patch fixes.
Create separate files for RWHVMac and RWHVCocoa https://chromium-review.googlesource.com/969404
The Great Blink mv for source files
The Great Blink mv for source files
Remove the Debian stretch sysroot https://chromium-review.googlesource.com/950310
Reland Touchscreen browser side fling and its follow up cls. https://chromium-review.googlesource.com/901959
Move rw_lock_wrapper.h to rtc_base/synchronization/ https://webrtc-review.googlesource.com/21328
Introduce interface between RWHVMac and RWHVCocoa https://chromium-review.googlesource.com/969975
Create a TYPE_CHUNKED_DATA_PIPE DataElement. https://chromium-review.googlesource.com/908828
There are errors about some generated headers not being available. It probably happens because of Jumbo builds. The Great Blink mv for source files, part 2 https://chromium-review.googlesource.com/1001153 Removes web/ lib and dependencies from Blink. https://chromium-review.googlesource.com/602093 Remove web/ finally!!! https://chromium-review.googlesource.com/606812 Move //components/filesystem to //components/services/ https://chromium-review.googlesource.com/c/chromium/src/+/948913
The Great Blink mv for source files, part 2 https://chromium-review.googlesource.com/1001153
macviews: fix menu transparency, remove some 10.9 code https://chromium-review.googlesource.com/987476 macviews: materialize macviews menus https://chromium-review.googlesource.com/998016
media: Add assert for "enable_widevine" gn arg https://chromium-review.googlesource.com/957707
Starting Chromium 67 we should move to libcc+Electron combined build so create-dist shouldn't be needed anymore anyway.
Update patches in preparation for the upgrade to Chromium 67 Included commits: 62ca2cf21c deps: cherry-pick 70c4340 from upstream V8 ab27e0e785 deps: cherry-pick acc336c from upstream V8 37a5c8c2ff deps: cherry-pick b20faff from upstream V8 4663d1c22e deps: backport aa6ce3e from upstream V8 5d7218965d deps: cherry-pick 5dd3395 from upstream V8 14bb905d18 deps: V8: cherry-pick a440efb27f from upstream 35d6661973 deps: cherry-pick 6989b3f6d7 from V8 upstream 4e788dc2f5 deps: backport 91ddb65d from upstream V8
* feat: implement ArrayBuffer realloc
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
2 times, most recently
from
ea6660d
to
5c06fcc
Compare
One of Electron's tests exposed the fact that boringssl didn't support the OCSP stapling APIs that nodejs was calling. This backports a patch from boringssl that adds the APIs that nodejs expects, and causes the test to pass.
For Node.js 10.6.0.
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
from
5c06fcc
to
5d57adf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Board https://github.com/electron/electron/projects/11
PR to Electron electron/electron#13756