Symlinks in node_modules cause ENOENT

[kaatt]

I have a symlinked dependency installed with yarn (link:../packages/foo), foo has another symlinked dependency bar.

When I run electron-rebuild, I get:

✖ Rebuild Failed

An unhandled error occurred inside electron-rebuild
ENOENT: no such file or directory, stat '/Users/kaatt/Code/packages/foo/node_modules/bar'

Error: ENOENT: no such file or directory, stat '/Users/kaatt/Code/packages/foo/node_modules/bar'

This doesn't go away until I delete the bar symlink.

[malept]

It would help if you could provide a concrete example with detailed repro steps, so we can use that to try to create a testcase inside the electron-rebuild testsuite.

[kaatt]

I figured out it works if the symlink is correct but not if it's invalid.

The bug here is that it's traversing node_modules in the parent folder even when --module-dir is present.

mkdir -p foo/app
cd foo
echo "{}" > package.json
echo "{}" > app/package.json
mkdir node_modules
mkdir app/node_modules
ln -s ./NONEXISTENT node_modules/bar
electron-rebuild --module-dir app/

###
✖ Rebuild Failed

An unhandled error occurred inside electron-rebuild
ENOENT: no such file or directory, stat '/Users/kaatt/Downloads/foo/node_modules/bar'

Error: ENOENT: no such file or directory, stat '/Users/kaatt/Downloads/foo/node_modules/bar'

Note that foo/node_modules contains the invalid symlink. foo/app/node_modules does not, yet electron-rebuild touches the parent directory.