Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Remove Python 2.6, add Python 3.6 #311

Merged
merged 4 commits into from
Nov 30, 2017
Merged

Remove Python 2.6, add Python 3.6 #311

merged 4 commits into from
Nov 30, 2017

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 16, 2017

Resolves #304.

Edit: CI 3.3 failure didn't on my build: https://travis-ci.org/hugovk/thriftpy/builds/288487124 Is it a known, transient error?

@hugovk
Copy link
Contributor Author

hugovk commented Oct 18, 2017

Here are pip installs from PyPI for the last month:

pypinfo --percent --pip thriftpy pyversion
python_version percent download_count
-------------- ------- --------------
2.7              71.9%         57,022
3.6              11.1%          8,821
3.4               8.6%          6,828
3.5               8.3%          6,554
2.6               0.1%            108
None              0.0%              8
3.3               0.0%              8
3.7               0.0%              4

Python 3.3 is also EOL, how about dropping that too?

@hugovk
Copy link
Contributor Author

hugovk commented Nov 12, 2017

@julioasotodv @hit9 Hello, any thoughts on this PR? Thank you!

@julioasotodv
Copy link

Yeah looks good to me. Nobody in py3 uses 3.3 anymore

@hugovk
Copy link
Contributor Author

hugovk commented Nov 13, 2017

PR updated to drop EOL Python 3.3.

(I get the same CI failure on latest develop: https://travis-ci.org/hugovk/thriftpy/builds/288453394)

@hugovk
Copy link
Contributor Author

hugovk commented Nov 26, 2017

@hit9 Hi, what do you think about this PR? Thank you.

@maralla maralla merged commit f450b7d into Thriftpy:develop Nov 30, 2017
@hugovk hugovk deleted the rm-2.6-add-3.6 branch November 30, 2017 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants