Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited message in thread with reaction throws error: Can't load this message (m.room.message) - Cannot read properties of null (reading 'getMyMembership') #22195

Closed
MadLittleMods opened this issue May 14, 2022 · 3 comments
Labels
A-Reactions A-Threads A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Soft-Crash React soft crash caught by an error boundary

Comments

@MadLittleMods
Copy link
Contributor

Steps to reproduce

  1. Start a thread
  2. Add some thread replies
  3. React to one of the replies
  4. Edit the reply you reacted to
  5. Clear cache and refresh
  6. Notice the thread now has a Can't load this message (m.room.message), Submit logs (tile error boundary) for the message in question
react_devtools_backend.js:3973 TypeError: Cannot read properties of null (reading 'getMyMembership')
   at ReactionsRow_ReactionsRow.render (ReactionsRow.tsx:170:32)
   at qi (react-dom.production.min.js:187:125)
   at pi (react-dom.production.min.js:186:166)
   at ck (react-dom.production.min.js:269:357)
   at bk (react-dom.production.min.js:250:341)
   at ak (react-dom.production.min.js:250:277)
   at Tj (react-dom.production.min.js:250:138)
   at Lj (react-dom.production.min.js:243:146)
   at react-dom.production.min.js:123:110
   at push.exports.unstable_runWithPriority (scheduler.production.min.js:18:336)
   at gg (react-dom.production.min.js:122:318)
   at jg (react-dom.production.min.js:123:61)
   at ig (react-dom.production.min.js:122:428)
   at Jg (react-dom.production.min.js:237:147)
   at Object.enqueueSetState (react-dom.production.min.js:133:211)
   at TimelinePanel_TimelinePanel.push.C.setState (react.production.min.js:12:356)
   at onLoaded (TimelinePanel.tsx:1279:18)

(spawned from #22157 (comment))

Outcome

What did you expect?

Message with reaction would load

What happened instead?

The tile error boundary was shown in place of the message: Can't load this message (m.room.message), Submit logs

Operating system

Windows 10

Browser information

Chrome Version 101.0.4951.64

URL for webapp

https://develop.element.io/

Application version

Element version: 479d4bf-react-5348572439be-js-4d4d6e1411b6 Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

No

@t3chguy
Copy link
Member

t3chguy commented May 14, 2022

Nothing in that stack says anything relating to threads, what makes you so sure for A-Threads and that it can't be reproduced in the main timeline?

@MadLittleMods
Copy link
Contributor Author

@t3chguy That's where it was reproduced. I don't know if the root cause is related to threads.

@robintown robintown added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels May 16, 2022
@t3chguy
Copy link
Member

t3chguy commented May 17, 2022

Same cause as #22141 - missing room object in store

@t3chguy t3chguy closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reactions A-Threads A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Soft-Crash React soft crash caught by an error boundary
Projects
None yet
Development

No branches or pull requests

3 participants