"Manually verify by text" does nothing

[MadLittleMods]

Steps to reproduce

1. Click on your avatar in the timeline of some room which will open your profile on the right side of the screen
2. In the Security section you should be able to click on your Hydrogen session
3. Click "Manually Verify by Text"
4. Make sure the Session ID and Session key match what is shown in the Hydrogen settings
5. Click the green Verify session button which
6. Notice that nothing seemed to happen except that the dialog was dismissed. The session still shows as unverified and going through the process over again has no effect.

1	2	3	4

(it's only possible to verify by text via the steps above because it's not in the session manager, see #20273)

Outcome

What did you expect?

My session would be become verified after I manually verified it. This used to work just fine.

It did work as expected when I tried from another Element Desktop session.

What happened instead?

No change and my sessions are still unverified. I don't even see a network request going out.

Operating system

Manjaro Linux 22.1.1 (Arch-based)

Browser information

Version 113.0.5672.92

URL for webapp

https://develop.element.io/

Application version

Element version: 88c5395-react-38c13509fd21-js-43160094019a Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

Yes

[luixxiul]

I think I noticed the same issue when I tried to verify a session of Hydrogen.

[dt-zero]

For anybody wondering, a temporary workaround can be to start a local instance of an older element-web version, e.g. sudo docker run --rm -p 80:80 vectorim/element-web:v1.11.13 and verify through that. I didn't bisect but I imagine this regressed at some point between that and current master. (as the bug also reproduces on the latest master version at the time of writing 945c079)

[kerryarchibald]

Regressed by matrix-org/matrix-react-sdk#10671

[MadLittleMods]

Thanks for investigating and fixing @kerryarchibald 🙂

[dannysemi]

Pretty sure this has regressed again. Trying to "manually verify by text" doesn't do anything when I click the button in the web ui. It doesn't even dismiss the message. I loaded up an older image (1.11.55) and it worked just fine.

[MrConorAE]

Yep, it's definitely regressed. Trying to click it prints this message to the console, if that helps:

17:32:33.039 Uncaught Error: End-to-end encryption disabled
    checkKeyBackup (client.ts:3385)
    setDeviceVerified (client.ts:2496)
    i (ManualDeviceKeyVerificationDialog.tsx:45)
    d (QuestionDialog.tsx:54)
    > React [11]
    unstable_runWithPriority (scheduler.production.min.js:18)
    > React [3]
17:32:33.045 Uncaught (in promise) Error: End-to-end encryption disabled
    setDeviceVerification (client.ts:2547)
    setDeviceVerified (client.ts:2490)
    i (ManualDeviceKeyVerificationDialog.tsx:45)
    d (QuestionDialog.tsx:54)
    > React [11]
    unstable_runWithPriority (scheduler.production.min.js:18)
    > React [3]

[kr428]

This seems still an issue I see. Is there any way to work around this, currently?

[worldowner]

Shouldn't this issue be re-opened? Clearly the issue reappeared.

[t3chguy]

@worldowner #27201

It doesn't work for an entirely different issue, so no shouldn't be reopened.

[worldowner]

Thank you for clarification. I didn't encounter the issue you've mentioned when I was browsing bug reports.