Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member URI (possibly) not correctly parsed in Pills #25535

Closed
MTRNord opened this issue Jun 7, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11060
Closed

Member URI (possibly) not correctly parsed in Pills #25535

MTRNord opened this issue Jun 7, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11060
Assignees
@t3chguy
Labels
A-Pills A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@MTRNord
Copy link
Contributor

MTRNord commented Jun 7, 2023 •
edited
Loading

Steps to reproduce

  1. Send a Pill with a href set to for example matrix:u/someuser:example.com?action=chat in a room

Outcome

What did you expect?

The user id should be parsed as @someuser:example.com and the Displayname resolved

What happened instead?

It doesn't strip the ?action=chat.
image
image

Operating system

Fedora Silverblue 38

Browser information

Firefox 113.0.1 (64-bit)

URL for webapp

develop.element.io

Application version

Version von Element: 569c904-react-34439ee652e6-js-a03e3dd5018b Version von Olm: 3.2.14

Homeserver

matrix.midnightthoughts.space

Will you send logs?

No
@MTRNord
Copy link
Contributor Author

MTRNord commented Jun 7, 2023 •
edited
Loading

See https://matrix.to/#/!NasysSDfxKxZBzJJoE:matrix.org/$QInAz7vZm5OO6LLzFMS0aWnV1fgrw_ORSVTapgL-QKo?via=matrix.org&via=libera.chat&via=element.io

for additional context on the spec side.

@MTRNord
Copy link
Contributor Author

MTRNord commented Jun 7, 2023

Oops nearly forgot. The origin of this bug is https://github.com/matrix-org/matrix-react-sdk/blob/34439ee652e6d01ecf0ab93fe859671b0542123c/src/utils/permalinks/MatrixSchemePermalinkConstructor.ts#L79-L81

@t3chguy t3chguy self-assigned this Jun 8, 2023
@t3chguy t3chguy mentioned this issue Jun 8, 2023
Merged
@kittykat kittykat added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Timeline A-Pills O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 8, 2023
su-ex added a commit to SchildiChat/element-web that referenced this issue Feb 22, 2024
@su-ex
Merge tag 'v1.11.34' into sc
6d4220e 
* OIDC: add delegatedauthentication to validated server config ([\element-hq#11053](matrix-org/matrix-react-sdk#11053)). Contributed by @kerryarchibald.
* Allow image pasting in plain mode in RTE ([\element-hq#11056](matrix-org/matrix-react-sdk#11056)). Contributed by @alunturner.
* Show room options menu if "UIComponent.roomOptionsMenu" is enabled ([\element-hq#10365](matrix-org/matrix-react-sdk#10365)). Contributed by @maheichyk.
* Allow image pasting in rich text mode in RTE ([\element-hq#11049](matrix-org/matrix-react-sdk#11049)). Contributed by @alunturner.
* Update voice broadcast redaction to use MSC3912 `with_rel_type` instead of `with_relations` ([\element-hq#11014](matrix-org/matrix-react-sdk#11014)). Fixes element-hq#25471.
* Add config to skip widget_build_url for DM rooms ([\element-hq#11044](matrix-org/matrix-react-sdk#11044)). Fixes vector-im/customer-retainer#74.
* Inhibit interactions on forward dialog message previews ([\element-hq#11025](matrix-org/matrix-react-sdk#11025)). Fixes element-hq#23459.
* Removed `DecryptionFailureBar.tsx` ([\element-hq#11027](matrix-org/matrix-react-sdk#11027)). Fixes element-hq/element-meta#1358. Contributed by @florianduros.
* Fix translucent `TextualEvent` on search results panel ([\element-hq#10810](matrix-org/matrix-react-sdk#10810)). Fixes element-hq#25292. Contributed by @luixxiul.
* Matrix matrix scheme permalink constructor not stripping query params ([\element-hq#11060](matrix-org/matrix-react-sdk#11060)). Fixes element-hq#25535.
* Fix: "manually verify by text" does nothing ([\element-hq#11059](matrix-org/matrix-react-sdk#11059)). Fixes element-hq#25375. Contributed by @kerryarchibald.
* Make group calls respect the ICE fallback setting ([\element-hq#11047](matrix-org/matrix-react-sdk#11047)). Fixes vector-im/voip-internal#65.
* Align list items on the tooltip to the start ([\element-hq#11041](matrix-org/matrix-react-sdk#11041)). Fixes element-hq#25355. Contributed by @luixxiul.
* Clear thread panel event permalink when changing rooms ([\element-hq#11024](matrix-org/matrix-react-sdk#11024)). Fixes element-hq#25484.
* Fix spinner placement on pinned widgets being reloaded ([\element-hq#10970](matrix-org/matrix-react-sdk#10970)). Fixes element-hq#25431. Contributed by @luixxiul.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Feb 22, 2024
@su-ex
Merge tag 'v3.74.0' into sc
00748e6 
* OIDC: add delegatedauthentication to validated server config ([\matrix-org#11053](matrix-org#11053)). Contributed by @kerryarchibald.
* Allow image pasting in plain mode in RTE ([\matrix-org#11056](matrix-org#11056)). Contributed by @alunturner.
* Show room options menu if "UIComponent.roomOptionsMenu" is enabled ([\matrix-org#10365](matrix-org#10365)). Contributed by @maheichyk.
* Allow image pasting in rich text mode in RTE ([\matrix-org#11049](matrix-org#11049)). Contributed by @alunturner.
* Update voice broadcast redaction to use MSC3912 `with_rel_type` instead of `with_relations` ([\matrix-org#11014](matrix-org#11014)). Fixes element-hq/element-web#25471.
* Add config to skip widget_build_url for DM rooms ([\matrix-org#11044](matrix-org#11044)). Fixes vector-im/customer-retainer#74.
* Inhibit interactions on forward dialog message previews ([\matrix-org#11025](matrix-org#11025)). Fixes element-hq/element-web#23459.
* Removed `DecryptionFailureBar.tsx` ([\matrix-org#11027](matrix-org#11027)). Fixes element-hq/element-meta#1358. Contributed by @florianduros.
* Fix translucent `TextualEvent` on search results panel ([\matrix-org#10810](matrix-org#10810)). Fixes element-hq/element-web#25292. Contributed by @luixxiul.
* Matrix matrix scheme permalink constructor not stripping query params ([\matrix-org#11060](matrix-org#11060)). Fixes element-hq/element-web#25535.
* Fix: "manually verify by text" does nothing ([\matrix-org#11059](matrix-org#11059)). Fixes element-hq/element-web#25375. Contributed by @kerryarchibald.
* Make group calls respect the ICE fallback setting ([\matrix-org#11047](matrix-org#11047)). Fixes vector-im/voip-internal#65.
* Align list items on the tooltip to the start ([\matrix-org#11041](matrix-org#11041)). Fixes element-hq/element-web#25355. Contributed by @luixxiul.
* Clear thread panel event permalink when changing rooms ([\matrix-org#11024](matrix-org#11024)). Fixes element-hq/element-web#25484.
* Fix spinner placement on pinned widgets being reloaded ([\matrix-org#10970](matrix-org#10970)). Fixes element-hq/element-web#25431. Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Pills A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Matrix matrix scheme permalink constructor not stripping query params matrix-org/matrix-react-sdk
3 participants
@kittykat @MTRNord @t3chguy