Allow image pasting in rich text mode in RTE #11049

alunturner · 2023-06-06T12:03:07Z

This PR enables a user to paste an image into the rich text mode of the rich text editor, behaviour matching that of the current composer. It requires a bump of the RTE to 2.2.2.

It does not allow pasting images into the plain text mode of the rich text editor (work to follow).

This is implemented by:

passing the eventRelation prop down to the composer
passing the eventRelation value to the inputEventProcessor
using the eventRelation and copying the existing logic as shown in SendMessageComposer.onPaste to handle image pasting
this handling is done by a new function, handleClipboardEvent
handleClipboardEvent is tested in a new test file, useInputEventProcessor-test

New behaviour:

Screen.Recording.2023-06-09.at.09.30.12.mov

Checklist

Tests written for new code (and old code if feasible)
Linter and other CI checks pass
Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

Allow image pasting in rich text mode in RTE (#11049). Contributed by @alunturner.

src/components/views/rooms/wysiwyg_composer/hooks/useInputEventProcessor.ts

…mage-investigation

alunturner · 2023-06-07T08:44:45Z

src/components/views/rooms/wysiwyg_composer/SendWysiwygComposer.tsx

-    eventRelation,
    ...props
 }: SendWysiwygComposerProps): JSX.Element {
    const Composer = isRichTextEnabled ? WysiwygComposer : PlainTextComposer;
-    const defaultContextValue = useRef(getDefaultContextValue({ eventRelation }));


This is to allow us to pass the eventRelation prop through to the composer as part of ...props

t3chguy

I don't think this will handle all image pastes, Safari sometimes pastes images as HTML entities which need to be captured onBeforeInput, it'd likely be best to try to de-dup code between the existing composer to ensure you do not miss any edge cases.

alunturner · 2023-06-08T11:00:29Z

Do you have any idea how to force that case in Safari? I've tested in Safari and it seems to work fine, but I couldn't find many current issues around it (there was a lot of stuff on image pasting in Safari from years ago, but nothing up to date).

In the meantime I'm going to try and figure out how to split the current composer functionality into the RTE repo and the react-sdk.

t3chguy · 2023-06-08T11:06:09Z

Do you have any idea how to force that case in Safari? I've tested in Safari and it seems to work fine, but I couldn't find many current issues around it (there was a lot of stuff on image pasting in Safari from years ago, but nothing up to date).

Its when you're inserting an image from your iPhone/iPad on your mac/book - i.e. element-hq/element-web#25327

alunturner · 2023-06-08T12:31:38Z

Putting back to draft for now as this is now going to be dependent on a change to RTE and need a version bump on that dependency.

@kerryarchibald

Changes in [1.11.34](https://github.com/vector-im/element-web/releases/tag/v1.11.34) (2023-06-20) ================================================================================================= ## ✨ Features * OIDC: add delegatedauthentication to validated server config ([\#11053](matrix-org/matrix-react-sdk#11053)). Contributed by @kerryarchibald. * Allow image pasting in plain mode in RTE ([\#11056](matrix-org/matrix-react-sdk#11056)). Contributed by @alunturner. * Show room options menu if "UIComponent.roomOptionsMenu" is enabled ([\#10365](matrix-org/matrix-react-sdk#10365)). Contributed by @maheichyk. * Allow image pasting in rich text mode in RTE ([\#11049](matrix-org/matrix-react-sdk#11049)). Contributed by @alunturner. * Update voice broadcast redaction to use MSC3912 `with_rel_type` instead of `with_relations` ([\#11014](matrix-org/matrix-react-sdk#11014)). Fixes #25471. * Add config to skip widget_build_url for DM rooms ([\#11044](matrix-org/matrix-react-sdk#11044)). Fixes vector-im/customer-retainer#74. * Inhibit interactions on forward dialog message previews ([\#11025](matrix-org/matrix-react-sdk#11025)). Fixes #23459. * Removed `DecryptionFailureBar.tsx` ([\#11027](matrix-org/matrix-react-sdk#11027)). Fixes element-hq/element-meta#1358. Contributed by @florianduros. ## 🐛 Bug Fixes * Fix translucent `TextualEvent` on search results panel ([\#10810](matrix-org/matrix-react-sdk#10810)). Fixes #25292. Contributed by @luixxiul. * Matrix matrix scheme permalink constructor not stripping query params ([\#11060](matrix-org/matrix-react-sdk#11060)). Fixes #25535. * Fix: "manually verify by text" does nothing ([\#11059](matrix-org/matrix-react-sdk#11059)). Fixes #25375. Contributed by @kerryarchibald. * Make group calls respect the ICE fallback setting ([\#11047](matrix-org/matrix-react-sdk#11047)). Fixes vector-im/voip-internal#65. * Align list items on the tooltip to the start ([\#11041](matrix-org/matrix-react-sdk#11041)). Fixes #25355. Contributed by @luixxiul. * Clear thread panel event permalink when changing rooms ([\#11024](matrix-org/matrix-react-sdk#11024)). Fixes #25484. * Fix spinner placement on pinned widgets being reloaded ([\#10970](matrix-org/matrix-react-sdk#10970)). Fixes #25431. Contributed by @luixxiul. Changes in [1.11.33](https://github.com/vector-im/element-web/releases/tag/v1.11.33) (2023-06-09) ================================================================================================= ## 🐛 Bug Fixes * Bump matrix-react-sdk to v3.73.1 for matrix-js-sdk v26.0.1. Fixes #25526. Changes in [1.11.32](https://github.com/vector-im/element-web/releases/tag/v1.11.32) (2023-06-06) ================================================================================================= ## ✨ Features * Redirect to the SSO page if `sso_redirect_options.on_welcome_page` is enabled and the URL hash is empty ([\#25495](element-hq/element-web#25495)). Contributed by @dhenneke. * vector/index.html: Allow fetching blob urls ([\#25336](element-hq/element-web#25336)). Contributed by @SuperKenVery. * When joining room in sub-space join the parents too ([\#11011](matrix-org/matrix-react-sdk#11011)). * Include thread replies in message previews ([\#10631](matrix-org/matrix-react-sdk#10631)). Fixes #23920. * Use semantic headings in space preferences ([\#11021](matrix-org/matrix-react-sdk#11021)). Contributed by @kerryarchibald. * Use semantic headings in user settings - Ignored users ([\#11006](matrix-org/matrix-react-sdk#11006)). Contributed by @kerryarchibald. * Use semantic headings in user settings - profile ([\#10973](matrix-org/matrix-react-sdk#10973)). Fixes #25461. Contributed by @kerryarchibald. * Use semantic headings in user settings - account ([\#10972](matrix-org/matrix-react-sdk#10972)). Contributed by @kerryarchibald. * Support `Insert from iPhone or iPad` in Safari ([\#10851](matrix-org/matrix-react-sdk#10851)). Fixes #25327. Contributed by @SuperKenVery. * Specify supportedStages for User Interactive Auth ([\#10975](matrix-org/matrix-react-sdk#10975)). Fixes #19605. * Pass device id to widgets ([\#10209](matrix-org/matrix-react-sdk#10209)). Contributed by @Fox32. * Use semantic headings in user settings - discovery ([\#10838](matrix-org/matrix-react-sdk#10838)). Contributed by @kerryarchibald. * Use semantic headings in user settings - Notifications ([\#10948](matrix-org/matrix-react-sdk#10948)). Contributed by @kerryarchibald. * Use semantic headings in user settings - spellcheck and language ([\#10959](matrix-org/matrix-react-sdk#10959)). Contributed by @kerryarchibald. * Use semantic headings in user settings Appearance ([\#10827](matrix-org/matrix-react-sdk#10827)). Contributed by @kerryarchibald. * Use semantic heading in user settings Sidebar & Voip ([\#10782](matrix-org/matrix-react-sdk#10782)). Contributed by @kerryarchibald. * Use semantic headings in user settings Security ([\#10774](matrix-org/matrix-react-sdk#10774)). Contributed by @kerryarchibald. * Use semantic headings in user settings - integrations and account deletion ([\#10837](matrix-org/matrix-react-sdk#10837)). Fixes #25378. Contributed by @kerryarchibald. * Use semantic headings in user settings Preferences ([\#10794](matrix-org/matrix-react-sdk#10794)). Contributed by @kerryarchibald. * Use semantic headings in user settings Keyboard ([\#10793](matrix-org/matrix-react-sdk#10793)). Contributed by @kerryarchibald. * RTE plain text mentions as pills ([\#10852](matrix-org/matrix-react-sdk#10852)). Contributed by @alunturner. * Allow welcome.html logo to be replaced by config ([\#25339](element-hq/element-web#25339)). Fixes #8636. * Use semantic headings in user settings Labs ([\#10773](matrix-org/matrix-react-sdk#10773)). Contributed by @kerryarchibald. * Use semantic list elements for menu lists and tab lists ([\#10902](matrix-org/matrix-react-sdk#10902)). Fixes #24928. * Fix aria-required-children axe violation ([\#10900](matrix-org/matrix-react-sdk#10900)). Fixes #25342. * Enable pagination for overlay timelines ([\#10757](matrix-org/matrix-react-sdk#10757)). Fixes vector-im/voip-internal#107. * Add tooltip to disabled invite button due to lack of permissions ([\#10869](matrix-org/matrix-react-sdk#10869)). Fixes #9824. * Respect configured auth_header_logo_url for default Welcome page ([\#10870](matrix-org/matrix-react-sdk#10870)). * Specify lazy loading for avatars ([\#10866](matrix-org/matrix-react-sdk#10866)). Fixes #1983. * Room and user mentions for plain text editor ([\#10665](matrix-org/matrix-react-sdk#10665)). Contributed by @alunturner. * Add audible notifcation on broadcast error ([\#10654](matrix-org/matrix-react-sdk#10654)). Fixes #25132. * Fall back from server generated thumbnail to original image ([\#10853](matrix-org/matrix-react-sdk#10853)). * Use semantically correct elements for room sublist context menu ([\#10831](matrix-org/matrix-react-sdk#10831)). Fixes vector-im/customer-retainer#46. * Avoid calling prepareToEncrypt onKeyDown ([\#10828](matrix-org/matrix-react-sdk#10828)). * Allows search to recognize full room links ([\#8275](matrix-org/matrix-react-sdk#8275)). Contributed by @bolu-tife. * "Show rooms with unread messages first" should not be on by default for new users ([\#10820](matrix-org/matrix-react-sdk#10820)). Fixes #25304. Contributed by @kerryarchibald. * Fix emitter handler leak in ThreadView ([\#10803](matrix-org/matrix-react-sdk#10803)). * Add better error for email invites without identity server ([\#10739](matrix-org/matrix-react-sdk#10739)). Fixes #16893. * Move reaction message previews out of labs ([\#10601](matrix-org/matrix-react-sdk#10601)). Fixes #25083. * Sort muted rooms to the bottom of their section of the room list ([\#10592](matrix-org/matrix-react-sdk#10592)). Fixes #25131. Contributed by @kerryarchibald. * Use semantic headings in user settings Help & About ([\#10752](matrix-org/matrix-react-sdk#10752)). Contributed by @kerryarchibald. * use ExternalLink components for external links ([\#10758](matrix-org/matrix-react-sdk#10758)). Contributed by @kerryarchibald. * Use semantic headings in space settings ([\#10751](matrix-org/matrix-react-sdk#10751)). Contributed by @kerryarchibald. * Use semantic headings for room settings content ([\#10734](matrix-org/matrix-react-sdk#10734)). Contributed by @kerryarchibald. ## 🐛 Bug Fixes * Use consistent fonts for Japanese text ([\#10980](matrix-org/matrix-react-sdk#10980)). Fixes #22333 and #23899. * Fix: server picker validates unselected option ([\#11020](matrix-org/matrix-react-sdk#11020)). Fixes #25488. Contributed by @kerryarchibald. * Fix room list notification badges going missing in compact layout ([\#11022](matrix-org/matrix-react-sdk#11022)). Fixes #25372. * Fix call to `startSingleSignOn` passing enum in place of idpId ([\#10998](matrix-org/matrix-react-sdk#10998)). Fixes #24953. * Remove hover effect from user name on a DM creation UI ([\#10887](matrix-org/matrix-react-sdk#10887)). Fixes #25305. Contributed by @luixxiul. * Fix layout regression in public space invite dialog ([\#11009](matrix-org/matrix-react-sdk#11009)). Fixes #25458. * Fix layout regression in session dropdown ([\#10999](matrix-org/matrix-react-sdk#10999)). Fixes #25448. * Fix spacing regression in user settings - roles & permissions ([\#10993](matrix-org/matrix-react-sdk#10993)). Fixes #25447 and #25451. Contributed by @kerryarchibald. * Fall back to receipt timestamp if we have no event (react-sdk part) ([\#10974](matrix-org/matrix-react-sdk#10974)). Fixes #10954. Contributed by @andybalaam. * Fix: Room header 'view your device list' does not link to new session manager ([\#10979](matrix-org/matrix-react-sdk#10979)). Fixes #25440. Contributed by @kerryarchibald. * Fix display of devices without encryption support in Settings dialog ([\#10977](matrix-org/matrix-react-sdk#10977)). Fixes #25413. * Use aria descriptions instead of labels for TextWithTooltip ([\#10952](matrix-org/matrix-react-sdk#10952)). Fixes #25398. * Use grapheme-splitter instead of lodash for saving emoji from being ripped apart ([\#10976](matrix-org/matrix-react-sdk#10976)). Fixes #22196. * Fix: content overflow in settings subsection ([\#10960](matrix-org/matrix-react-sdk#10960)). Fixes #25416. Contributed by @kerryarchibald. * Make `Privacy Notice` external link on integration manager ToS clickable ([\#10914](matrix-org/matrix-react-sdk#10914)). Fixes #25384. Contributed by @luixxiul. * Ensure that open message context menus are updated when the event is sent ([\#10950](matrix-org/matrix-react-sdk#10950)). * Ensure that open sticker picker dialogs are updated when the widget configuration is updated. ([\#10945](matrix-org/matrix-react-sdk#10945)). * Fix big emoji in replies ([\#10932](matrix-org/matrix-react-sdk#10932)). Fixes #24798. * Hide empty `MessageActionBar` on message edit history dialog ([\#10447](matrix-org/matrix-react-sdk#10447)). Fixes #24903. Contributed by @luixxiul. * Fix roving tab index getting confused after dragging space order ([\#10901](matrix-org/matrix-react-sdk#10901)). * Attempt a potential workaround for stuck notifs ([\#3384](matrix-org/matrix-js-sdk#3384)). Fixes element-hq/element-web#25406. Contributed by @andybalaam. * Handle trailing dot FQDNs for domain-specific config.json files ([\#25351](element-hq/element-web#25351)). Fixes #8858. * Ignore edits in message previews when they concern messages other than latest ([\#10868](matrix-org/matrix-react-sdk#10868)). Fixes #14872. * Send correct receipts when viewing a room ([\#10864](matrix-org/matrix-react-sdk#10864)). Fixes #25196. * Fix timeline search bar being overlapped by the right panel ([\#10809](matrix-org/matrix-react-sdk#10809)). Fixes #25291. Contributed by @luixxiul. * Fix the state shown for call in rooms ([\#10833](matrix-org/matrix-react-sdk#10833)). * Add string for membership event where both displayname & avatar change ([\#10880](matrix-org/matrix-react-sdk#10880)). Fixes #18026. * Fix people space notification badge not updating for new DM invites ([\#10849](matrix-org/matrix-react-sdk#10849)). Fixes #23248. * Fix regression in emoji picker order mangling after clearing filter ([\#10854](matrix-org/matrix-react-sdk#10854)). Fixes #25323. * Fix: Edit history modal crash ([\#10834](matrix-org/matrix-react-sdk#10834)). Fixes #25309. Contributed by @kerryarchibald. * Fix long room address and name not being clipped on room info card and update `_RoomSummaryCard.pcss` ([\#10811](matrix-org/matrix-react-sdk#10811)). Fixes #25293. Contributed by @luixxiul. * Treat thumbnail upload failures as complete upload failures ([\#10829](matrix-org/matrix-react-sdk#10829)). Fixes #7069. * Update finite automata to match user identifiers as per spec ([\#10798](matrix-org/matrix-react-sdk#10798)). Fixes #25246. * Fix icon on empty notification panel ([\#10817](matrix-org/matrix-react-sdk#10817)). Fixes #25298 and #25302. Contributed by @luixxiul. * Fix: Threads button is highlighted when I create a new room ([\#10819](matrix-org/matrix-react-sdk#10819)). Fixes #25284. Contributed by @kerryarchibald. * Fix the top heading of notification panel ([\#10818](matrix-org/matrix-react-sdk#10818)). Fixes #25303. Contributed by @luixxiul. * Fix the color of the verified E2EE icon on `RoomSummaryCard` ([\#10812](matrix-org/matrix-react-sdk#10812)). Fixes #25295. Contributed by @luixxiul. * Fix: No feedback when waiting for the server on a /delete_devices request with SSO ([\#10795](matrix-org/matrix-react-sdk#10795)). Fixes #23096. Contributed by @kerryarchibald. * Fix: reveal images when image previews are disabled ([\#10781](matrix-org/matrix-react-sdk#10781)). Fixes #25271. Contributed by @kerryarchibald. * Fix accessibility issues around the room list and space panel ([\#10717](matrix-org/matrix-react-sdk#10717)). Fixes #13345. * Ensure tooltip contents is linked via aria to the target element ([\#10729](matrix-org/matrix-react-sdk#10729)). Fixes vector-im/customer-retainer#43. Changes in [1.11.31](https://github.com/vector-im/element-web/releases/tag/v1.11.31) (2023-05-10) ================================================================================================= ## ✨ Features * Improve Content-Security-Policy ([\#25210](element-hq/element-web#25210)). * Add UIFeature.locationSharing to hide location sharing ([\#10727](matrix-org/matrix-react-sdk#10727)). * Memoize field validation results ([\#10714](matrix-org/matrix-react-sdk#10714)). * Commands for plain text editor ([\#10567](matrix-org/matrix-react-sdk#10567)). Contributed by @alunturner. * Allow 16 lines of text in the rich text editors ([\#10670](matrix-org/matrix-react-sdk#10670)). Contributed by @alunturner. * Bail out of `RoomSettingsDialog` when room is not found ([\#10662](matrix-org/matrix-react-sdk#10662)). Contributed by @kerryarchibald. * Element-R: Populate device list for right-panel ([\#10671](matrix-org/matrix-react-sdk#10671)). Contributed by @florianduros. * Make existing and new issue URLs configurable ([\#10710](matrix-org/matrix-react-sdk#10710)). Fixes #24424. * Fix usages of ARIA tabpanel ([\#10628](matrix-org/matrix-react-sdk#10628)). Fixes #25016. * Element-R: Starting a DMs with a user ([\#10673](matrix-org/matrix-react-sdk#10673)). Contributed by @florianduros. * ARIA Accessibility improvements ([\#10675](matrix-org/matrix-react-sdk#10675)). * ARIA Accessibility improvements ([\#10674](matrix-org/matrix-react-sdk#10674)). * Add arrow key controls to emoji and reaction pickers ([\#10637](matrix-org/matrix-react-sdk#10637)). Fixes #17189. * Translate credits in help about section ([\#10676](matrix-org/matrix-react-sdk#10676)). ## 🐛 Bug Fixes * Fix: reveal images when image previews are disabled ([\#10781](matrix-org/matrix-react-sdk#10781)). Fixes #25271. Contributed by @kerryarchibald. * Fix autocomplete not resetting properly on message send ([\#10741](matrix-org/matrix-react-sdk#10741)). Fixes #25170. * Fix start_sso not working with guests disabled ([\#10720](matrix-org/matrix-react-sdk#10720)). Fixes #16624. * Fix soft crash with Element call widgets ([\#10684](matrix-org/matrix-react-sdk#10684)). * Send correct receipt when marking a room as read ([\#10730](matrix-org/matrix-react-sdk#10730)). Fixes #25207. * Offload some more waveform processing onto a worker ([\#9223](matrix-org/matrix-react-sdk#9223)). Fixes #19756. * Consolidate login errors ([\#10722](matrix-org/matrix-react-sdk#10722)). Fixes #17520. * Fix all rooms search generating permalinks to wrong room id ([\#10625](matrix-org/matrix-react-sdk#10625)). Fixes #25115. * Posthog properly handle Analytics ID changing from under us ([\#10702](matrix-org/matrix-react-sdk#10702)). Fixes #25187. * Fix Clock being read as an absolute time rather than duration ([\#10706](matrix-org/matrix-react-sdk#10706)). Fixes #22582. * Properly translate errors in `ChangePassword.tsx` so they show up translated to the user but not in our logs ([\#10615](matrix-org/matrix-react-sdk#10615)). Fixes #9597. Contributed by @MadLittleMods. * Honour feature toggles in guest mode ([\#10651](matrix-org/matrix-react-sdk#10651)). Fixes #24513. Contributed by @andybalaam. * Fix default content in devtools event sender ([\#10699](matrix-org/matrix-react-sdk#10699)). Contributed by @tulir. * Fix a crash when a call ends while you're in it ([\#10681](matrix-org/matrix-react-sdk#10681)). Fixes #25153. * Fix lack of screen reader indication when triggering auto complete ([\#10664](matrix-org/matrix-react-sdk#10664)). Fixes #11011. * Fix typing tile duplicating users ([\#10678](matrix-org/matrix-react-sdk#10678)). Fixes #25165. * Fix wrong room topic tooltip position ([\#10667](matrix-org/matrix-react-sdk#10667)). Fixes #25158. * Fix create subspace dialog not working ([\#10652](matrix-org/matrix-react-sdk#10652)). Fixes #24882.

@kerryarchibald

* OIDC: add delegatedauthentication to validated server config ([\element-hq#11053](matrix-org/matrix-react-sdk#11053)). Contributed by @kerryarchibald. * Allow image pasting in plain mode in RTE ([\element-hq#11056](matrix-org/matrix-react-sdk#11056)). Contributed by @alunturner. * Show room options menu if "UIComponent.roomOptionsMenu" is enabled ([\element-hq#10365](matrix-org/matrix-react-sdk#10365)). Contributed by @maheichyk. * Allow image pasting in rich text mode in RTE ([\element-hq#11049](matrix-org/matrix-react-sdk#11049)). Contributed by @alunturner. * Update voice broadcast redaction to use MSC3912 `with_rel_type` instead of `with_relations` ([\element-hq#11014](matrix-org/matrix-react-sdk#11014)). Fixes element-hq#25471. * Add config to skip widget_build_url for DM rooms ([\element-hq#11044](matrix-org/matrix-react-sdk#11044)). Fixes vector-im/customer-retainer#74. * Inhibit interactions on forward dialog message previews ([\element-hq#11025](matrix-org/matrix-react-sdk#11025)). Fixes element-hq#23459. * Removed `DecryptionFailureBar.tsx` ([\element-hq#11027](matrix-org/matrix-react-sdk#11027)). Fixes element-hq/element-meta#1358. Contributed by @florianduros. * Fix translucent `TextualEvent` on search results panel ([\element-hq#10810](matrix-org/matrix-react-sdk#10810)). Fixes element-hq#25292. Contributed by @luixxiul. * Matrix matrix scheme permalink constructor not stripping query params ([\element-hq#11060](matrix-org/matrix-react-sdk#11060)). Fixes element-hq#25535. * Fix: "manually verify by text" does nothing ([\element-hq#11059](matrix-org/matrix-react-sdk#11059)). Fixes element-hq#25375. Contributed by @kerryarchibald. * Make group calls respect the ICE fallback setting ([\element-hq#11047](matrix-org/matrix-react-sdk#11047)). Fixes vector-im/voip-internal#65. * Align list items on the tooltip to the start ([\element-hq#11041](matrix-org/matrix-react-sdk#11041)). Fixes element-hq#25355. Contributed by @luixxiul. * Clear thread panel event permalink when changing rooms ([\element-hq#11024](matrix-org/matrix-react-sdk#11024)). Fixes element-hq#25484. * Fix spinner placement on pinned widgets being reloaded ([\element-hq#10970](matrix-org/matrix-react-sdk#10970)). Fixes element-hq#25431. Contributed by @luixxiul.

@kerryarchibald

* OIDC: add delegatedauthentication to validated server config ([\matrix-org#11053](matrix-org#11053)). Contributed by @kerryarchibald. * Allow image pasting in plain mode in RTE ([\matrix-org#11056](matrix-org#11056)). Contributed by @alunturner. * Show room options menu if "UIComponent.roomOptionsMenu" is enabled ([\matrix-org#10365](matrix-org#10365)). Contributed by @maheichyk. * Allow image pasting in rich text mode in RTE ([\matrix-org#11049](matrix-org#11049)). Contributed by @alunturner. * Update voice broadcast redaction to use MSC3912 `with_rel_type` instead of `with_relations` ([\matrix-org#11014](matrix-org#11014)). Fixes element-hq/element-web#25471. * Add config to skip widget_build_url for DM rooms ([\matrix-org#11044](matrix-org#11044)). Fixes vector-im/customer-retainer#74. * Inhibit interactions on forward dialog message previews ([\matrix-org#11025](matrix-org#11025)). Fixes element-hq/element-web#23459. * Removed `DecryptionFailureBar.tsx` ([\matrix-org#11027](matrix-org#11027)). Fixes element-hq/element-meta#1358. Contributed by @florianduros. * Fix translucent `TextualEvent` on search results panel ([\matrix-org#10810](matrix-org#10810)). Fixes element-hq/element-web#25292. Contributed by @luixxiul. * Matrix matrix scheme permalink constructor not stripping query params ([\matrix-org#11060](matrix-org#11060)). Fixes element-hq/element-web#25535. * Fix: "manually verify by text" does nothing ([\matrix-org#11059](matrix-org#11059)). Fixes element-hq/element-web#25375. Contributed by @kerryarchibald. * Make group calls respect the ICE fallback setting ([\matrix-org#11047](matrix-org#11047)). Fixes vector-im/voip-internal#65. * Align list items on the tooltip to the start ([\matrix-org#11041](matrix-org#11041)). Fixes element-hq/element-web#25355. Contributed by @luixxiul. * Clear thread panel event permalink when changing rooms ([\matrix-org#11024](matrix-org#11024)). Fixes element-hq/element-web#25484. * Fix spinner placement on pinned widgets being reloaded ([\matrix-org#10970](matrix-org#10970)). Fixes element-hq/element-web#25431. Contributed by @luixxiul.

Alun Turner added 4 commits June 6, 2023 10:52

add comments to rough first solution

563fefa

allow eventRelation prop to pass to both composers

ac89c45

use eventRelation in image paste

eddb25a

add image pasting to rich text mode of rich text editor

5193f2b

github-actions bot deployed to Netlify June 6, 2023 12:07 View deployment

github-advanced-security bot found potential problems Jun 6, 2023

View reviewed changes

src/components/views/rooms/wysiwyg_composer/hooks/useInputEventProcessor.ts Fixed Show fixed Hide fixed

alunturner added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jun 6, 2023

extract error handling to function

5cc2442

github-actions bot deployed to Netlify June 6, 2023 12:43 View deployment

type the error handler

1853439

github-actions bot deployed to Netlify June 6, 2023 13:37 View deployment

Alun Turner added 2 commits June 6, 2023 17:30

add tests

ff22566

make behaviour mimic SendMessage

c22510f

github-actions bot deployed to Netlify June 6, 2023 16:36 View deployment

Alun Turner added 2 commits June 7, 2023 09:11

add sad path tests

2f70f31

refactor to use catch throughout

5ae4ff6

github-actions bot had a problem deploying to Netlify June 7, 2023 08:16 Failure

update comments

14a62c7

github-actions bot had a problem deploying to Netlify June 7, 2023 08:54 Failure

Alun Turner added 2 commits June 7, 2023 10:06

tidy up tests

e342e78

Merge remote-tracking branch 'origin/develop' into alunturner/paste-i…

c92663e

…mage-investigation

github-actions bot deployed to Netlify June 7, 2023 09:13 View deployment

alunturner commented Jun 7, 2023

View reviewed changes

alunturner marked this pull request as ready for review June 7, 2023 09:25

alunturner requested a review from a team as a code owner June 7, 2023 09:25

alunturner requested review from t3chguy and kerryarchibald June 7, 2023 09:25

alunturner changed the title ~~Allow image pasting in the rich text editor~~ Allow image pasting in the rich text mode in RTE Jun 7, 2023

t3chguy reviewed Jun 8, 2023

View reviewed changes

add special case and change function signature

dafe585

alunturner marked this pull request as draft June 8, 2023 12:31

github-actions bot deployed to Netlify June 8, 2023 12:41 View deployment

alunturner changed the title ~~Allow image pasting in the rich text mode in RTE~~ Allow image pasting in rich text mode in RTE Jun 9, 2023

Merge branch 'develop' into alunturner/paste-image-investigation

8645740

alunturner marked this pull request as ready for review June 9, 2023 08:26

github-actions bot deployed to Netlify June 9, 2023 08:30 View deployment

alunturner requested a review from t3chguy June 9, 2023 08:33

Alun Turner added 2 commits June 9, 2023 09:38

add comment

77ccbf8

bump rte to 2.2.2

3a433fe

alunturner requested a review from a team as a code owner June 9, 2023 08:39

github-actions bot deployed to Netlify June 9, 2023 08:44 View deployment

t3chguy approved these changes Jun 9, 2023

View reviewed changes

alunturner added this pull request to the merge queue Jun 9, 2023

Merged via the queue into develop with commit 53415bf Jun 9, 2023
78 checks passed

alunturner deleted the alunturner/paste-image-investigation branch June 9, 2023 09:38

This was referenced Jun 12, 2023

Allow image pasting in plain mode in RTE #11056

Merged

Pasting images from clipboard matrix-org/matrix-rich-text-editor#696

Closed

alunturner mentioned this pull request Jun 19, 2023

[Rich text editor] Pasting picture from the clipboard didn't work element-hq/element-web#23870

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow image pasting in rich text mode in RTE #11049

Allow image pasting in rich text mode in RTE #11049

alunturner commented Jun 6, 2023 •

edited by github-actions bot

alunturner Jun 7, 2023

t3chguy left a comment

alunturner commented Jun 8, 2023 •

edited

t3chguy commented Jun 8, 2023

alunturner commented Jun 8, 2023 •

edited

Allow image pasting in rich text mode in RTE #11049

Allow image pasting in rich text mode in RTE #11049

Conversation

alunturner commented Jun 6, 2023 • edited by github-actions bot

Checklist

✨ Features

alunturner Jun 7, 2023

Choose a reason for hiding this comment

t3chguy left a comment

Choose a reason for hiding this comment

alunturner commented Jun 8, 2023 • edited

t3chguy commented Jun 8, 2023

alunturner commented Jun 8, 2023 • edited

alunturner commented Jun 6, 2023 •

edited by github-actions bot

alunturner commented Jun 8, 2023 •

edited

alunturner commented Jun 8, 2023 •

edited