Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility confusion regarding message input field #9141

Closed
ndarilek opened this issue Mar 12, 2019 · 8 comments
Closed

Accessibility confusion regarding message input field #9141

ndarilek opened this issue Mar 12, 2019 · 8 comments
Labels
A11y P2 T-Defect
Milestone
Accessibility Imp...

Comments

@ndarilek
Copy link
Contributor

Description

I'm a screen reader user confused by the message input field. It seems to be non-keyboard-accessible until I click it, at which point I can enter text. At some point, the ability to enter text goes away until I click the field again.

Is something happening where the field is invisible until some action makes it appear, but that visual appearance isn't being conveyed to my screen reader?

Version information

  • Platform: web

For the web app:

  • Browser: Firefox/Chrome, multiple versions
  • OS: Linux, Chrome OS
  • URL: riot.im/app
@jryans
Copy link
Collaborator

jryans commented Mar 13, 2019

Thanks for the report!

Hmm, I don't see any changes to the DOM when the message input is focused vs. unfocused...

The message input is marked with role="textbox". However, I am not seeing the message input appear in an obvious way the accessibility debugging tools.

We may need to try more debugging here with a screen reader to see what's wrong.

@lampholder
Copy link
Member

Which screen reader are you using?

@lampholder lampholder added X-Needs-Info This issue is blocked awaiting information from the reporter type:composer I18n labels Mar 15, 2019
@ndarilek
Copy link
Contributor Author

ndarilek commented Mar 15, 2019 via email

@lampholder
Copy link
Member

We have an item on our roadmap: "Simple, stable composer" which we might well tackle as part of our upcoming making-messages-editable effort, that will replace the current composer with something as simple as possible to minimise maintenance burden and maximise compatibility.

We should check for screenreader compatibility when we implement that composer.

@lampholder lampholder added T-Defect P2 and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Apr 4, 2019
@turt2live turt2live added this to the Accessibility Improvements milestone May 16, 2019
@turt2live
Copy link
Member

Message entry text box contains non-editable text when empty. This makes it impossible to focus this control from screen reader browse mode.

from moz feedback

@t3chguy
Copy link
Member

t3chguy commented Sep 30, 2019 •
edited
Loading

This this CIDER or Slate?
If CIDER then https://github.com/matrix-org/matrix-react-sdk/pull/3497/files#diff-334804109a89457b8cc14800ce92e4c0R554 may help

@turt2live
Copy link
Member

almost certainly Slate, unfortunately (for both the OP and moz). CIDER is a labs option, and the OP is on /app, as is moz.

iirc we're close to shipping CIDER though, so fixing it for CIDER should be fine imo.

@t3chguy
Copy link
Member

t3chguy commented Oct 29, 2019

Closing assuming fixed until told otherwise given we've shipped CIDER

@t3chguy t3chguy closed this as completed Oct 29, 2019
@jryans jryans added A11y and removed I18n labels Mar 5, 2021
su-ex added a commit to SchildiChat/element-web that referenced this issue Aug 22, 2022
@su-ex
Merge tag 'v1.11.3' into sc
d397360 
* Improve auth aria attributes and semantics ([\element-hq#22948](element-hq#22948)).
* Device manager - New device tile info design ([\element-hq#9122](matrix-org/matrix-react-sdk#9122)). Contributed by @kerryarchibald.
* Device manager generic settings subsection component ([\element-hq#9147](matrix-org/matrix-react-sdk#9147)). Contributed by @kerryarchibald.
* Migrate the hidden read receipts flag to new "send read receipts" option ([\element-hq#9141](matrix-org/matrix-react-sdk#9141)).
* Live location sharing - share location at most every 5 seconds ([\element-hq#9148](matrix-org/matrix-react-sdk#9148)). Contributed by @kerryarchibald.
* Increase max length of voice messages to 15m ([\element-hq#9133](matrix-org/matrix-react-sdk#9133)). Fixes element-hq#18620.
* Move pin drop out of labs ([\element-hq#9135](matrix-org/matrix-react-sdk#9135)).
* Start DM on first message ([\element-hq#8612](matrix-org/matrix-react-sdk#8612)). Fixes element-hq#14736.
* Remove "Add Space" button from RoomListHeader when user cannot create spaces ([\element-hq#9129](matrix-org/matrix-react-sdk#9129)).
* The Welcome Home Screen: Dedicated Download Apps Dialog ([\element-hq#9120](matrix-org/matrix-react-sdk#9120)). Fixes element-hq#22921. Contributed by @justjanne.
* The Welcome Home Screen: "Submit Feedback" pane ([\element-hq#9090](matrix-org/matrix-react-sdk#9090)). Fixes element-hq#22918. Contributed by @justjanne.
* New User Onboarding Task List ([\element-hq#9083](matrix-org/matrix-react-sdk#9083)). Fixes element-hq#22919. Contributed by @justjanne.
* Add support for disabling spell checking ([\element-hq#8604](matrix-org/matrix-react-sdk#8604)). Fixes element-hq#21901.
* Live location share - leave maximised map open when beacons expire ([\element-hq#9098](matrix-org/matrix-react-sdk#9098)). Contributed by @kerryarchibald.
* Some slash-commands (`/myroomnick`) have temporarily been disabled before the first message in a DM is sent. ([\element-hq#9193](matrix-org/matrix-react-sdk#9193)).
* Use stable reference for active tab in tabbedView ([\#9145](matrix-org/matrix-react-sdk#9145)). Contributed by @kerryarchibald.
* Fix pillification sometimes doubling up ([\element-hq#9152](matrix-org/matrix-react-sdk#9152)). Fixes element-hq#23036.
* Fix highlights not being applied to plaintext messages ([\element-hq#9126](matrix-org/matrix-react-sdk#9126)). Fixes element-hq#22787.
* Fix dismissing edit composer when change was undone ([\element-hq#9109](matrix-org/matrix-react-sdk#9109)). Fixes element-hq#22932.
* 1-to-1 DM rooms with bots now act like DM rooms instead of multi-user-rooms before ([\element-hq#9124](matrix-org/matrix-react-sdk#9124)). Fixes element-hq#22894.
* Apply inline start padding to selected lines on modern layout only ([\element-hq#9006](matrix-org/matrix-react-sdk#9006)). Fixes element-hq#22768. Contributed by @luixxiul.
* Peek into world-readable rooms from spotlight ([\element-hq#9115](matrix-org/matrix-react-sdk#9115)). Fixes element-hq#22862.
* Use default styling on nested numbered lists due to MD being sensitive ([\element-hq#9110](matrix-org/matrix-react-sdk#9110)). Fixes element-hq#22935.
* Fix replying using chat effect commands ([\element-hq#9101](matrix-org/matrix-react-sdk#9101)). Fixes element-hq#22824.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11y P2 T-Defect
Projects
None yet
Milestone
Accessibility Improvements
Development

No branches or pull requests
5 participants
@ndarilek @jryans @turt2live @lampholder @t3chguy