Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot icon disappears after upgrade to 1.2.0 #9897

Closed
hooger opened this issue May 30, 2019 · 26 comments · Fixed by #10097
Closed

Riot icon disappears after upgrade to 1.2.0 #9897

hooger opened this issue May 30, 2019 · 26 comments · Fixed by #10097
Assignees
@jryans
Labels
A-Electron P2 T-Defect X-Regression

Comments

@hooger
Copy link

hooger commented May 30, 2019

Description

After upgrading to 1.2.0 from 1.1.2 the icon of Riot disappears from the taskbar (so I cannot focus it in case of minimizing), and on the window list the icon is not the official icon, but a regular "some window" icon.

Steps to reproduce

  • Shut down riot-web
  • Upgrade to riot-web 1.2.0 from 1.1.2
  • Start riot-web
  • Icon on the window list is not good, and there is no icon on the tray or taskbar
  • Have the setting "The close button puts the application down on the tray" enabled (this message is a google translated version of the original hungarian that I see)
  • Hit the close button
  • Application disappears (but still running, based on ps, and "restarting" it from menu calls it pretty quick)

Describe how what happens differs from what you expected:

  • I want my icons back :D (sry for strong phrasing)

kép

Red circle shows the wrong icon display, blue circle shows where the Riot icon was right before I upgraded.

Version information

  • Platform: web (in-browser) or desktop?

For the desktop app:

  • OS: Debian stable, up-to-date at the time of bug report creation
  • Version: 1.2.0
@hooger
Copy link
Author

hooger commented May 30, 2019

Interesting! When the first message arrived, the Riot icons automagically appeared with the number in bubble and after I read the new message, and the notification was gone, the icon stayed. However after restarting the app the issue resurfaces. This is still a bug, that needs to be addressed I think, but at least I can live with that.

@jryans
Copy link
Collaborator

jryans commented May 30, 2019

Thanks for the report! That is definitely strange and unexpected. We've had a lot of trouble with those icons in desktop builds... At the moment, I'm not sure what would cause that, but let's keep this issue open and see if it affects others as well.

@Me4Linux
Copy link

Same here. After upgrading to 1.2.0 and restarting my systems (Xubuntu 16.04 and Debian 9) there's no Riot.im symbol in the notification area.

@edwardando
Copy link

I confirm: the tray icon has gone for me too on Debian Stretch with Openbox

@jryans
Copy link
Collaborator

jryans commented May 30, 2019 •
edited
Loading

Hmm, very curious. I have asked #riot-web:matrix.org, and some Linux users do have the app icon still, so we'll need to look for some kind of root cause here.

As far as I know, nothing was changed in Riot with the icon art... We did change from Electron 4.1.5 to 4.2.2 for Riot 1.2.0, so it's possible that is related to the issue here.

@jryans
Copy link
Collaborator

jryans commented May 30, 2019

I don't see any changes to app icons in Electron changelog between those versions (but of course it's still possible that something may have changed anyway).

Electron 5 does mention some fixes in this area, but it's unclear if they'll help with this issue.

@prurigro prurigro mentioned this issue May 30, 2019
Closed
@adrianiainlam
Copy link

Same here, Ubuntu 16.04

@mrdumpty
Copy link

mrdumpty commented May 31, 2019 •
edited
Loading

Same here, Linux Mint 19.1 Tessa (Mate version)
No Riot icon on system tray.

@lampholder lampholder mentioned this issue May 31, 2019
Closed
@adrianiainlam
Copy link

Suddenly started working for me again, after someone messaged me.

@Me4Linux
Copy link

Asked some friends to message me and as soon as one of them did there's the symbol back again. But after closing and reopening the client the bug's also back.

@vsatmydynipnet
Copy link

Debian Buster and Sid, XFCE, riot-web 1.2.1 the problem is still there.

@erciccione
Copy link

erciccione commented Jun 2, 2019 •
edited
Loading

+1 on Debian sid (Gnome), riot 1.2.1, but i had this problem before. It was usually necessary to wait some minutes and the icon would appear, but now nothing show up unless i get pinged.

@mrdumpty
Copy link

mrdumpty commented Jun 3, 2019

The bug still exists with 1.2.1, icon appears only when receiving first message after startup. Linux Mint 19.1 Tessa (Mate version).

@i47320673
Copy link

Linux Mint 17.3
The same issue in 1.2.1.
1.1.2 works fine.

@erciccione erciccione mentioned this issue Jun 9, 2019
Closed
@Fzorkas
Copy link

Fzorkas commented Jun 9, 2019

Bug also exists for me. Linux Mint 19 Tara MATE.

@heini
Copy link

heini commented Jun 10, 2019

Same here.

Debian Buster, KDE, Riot-Web 1.2.1.

@DoctorSubtilis
Copy link

Also here, Kubuntu 18.04, Riot-web 1.2.1

@anjannath
Copy link

So i use riot from flathub, update to version 1.2.1, and faced the same issue, running on Fedora 30

@dbkr
Copy link
Member

dbkr commented Jun 14, 2019

@jryans any chance this could have been triggered by the change to the favicon code to avoid using the canvas on startup? ie. there's some problem with the icon file we're providing but once we update the favicon with canvas, it works spits out a PNG which is fine?

@jryans
Copy link
Collaborator

jryans commented Jun 17, 2019

@jryans any chance this could have been triggered by the change to the favicon code to avoid using the canvas on startup? ie. there's some problem with the icon file we're providing but once we update the favicon with canvas, it works spits out a PNG which is fine?

Hmm, I agree the timing is suspicious, as the change to delay favicons first appeared in Riot 1.2.0. At the moment though, I can't reproduce this issue with Riot 1.2.1 on Ubuntu 18.04.2. I'll investigate further, as there's clearly a variety of system configurations affected.

@jryans jryans self-assigned this Jun 17, 2019
@jryans jryans added the defect label Jun 17, 2019
@jryans jryans added this to In Progress in Web App Team via automation Jun 17, 2019
@jryans jryans removed the defect label Jun 17, 2019
@DoctorSubtilis
Copy link

Today, I don't know why and how, the riot tray icon is reappeared.

@jryans
Copy link
Collaborator

jryans commented Jun 18, 2019

The icon should reappear once you receive a notification. Only the default app icon at startup (before the first notification) appears to be affected. I'm working on a fix for the default case now.

@DoctorSubtilis
Copy link

Ah, ok. Thank you!

@edwardando
Copy link

After a rare restart mine is back too!

jryans added a commit that referenced this issue Jun 18, 2019
@jryans
Fix reference to main window when setting Electron window icon
f10e7ac 
This fixes the fallback path which sets the Electron window icon to the default
icon in case there's no data URI based icon coming content. This is true
immediately after startup, for example.

Part of #9897
jryans added a commit that referenced this issue Jun 18, 2019
@jryans
Move default Electron icons outside ASAR
e88de35 
Electron doesn't seem to want to load icons from within ASARs, so this changes
the default icons (used for window and tray) so that they are just regular files
on disk and updates the reference to match.

Part of #9897
jryans added a commit that referenced this issue Jun 18, 2019
@jryans
Update Electron's runtime PNG icon to match others
a43d5ac 
This runtime PNG icon (the default window and tray icon) was not updated to
remove the white background when we last changed the branding. This copies a 265
px PNG from elsewhere to ensure it matches.

Part of #9897
@jryans jryans mentioned this issue Jun 18, 2019
Merged
@jryans jryans moved this from In Progress to In Review in Web App Team Jun 18, 2019
jryans added a commit that referenced this issue Jun 18, 2019
@jryans
Move default Electron icons outside asar
292427c 
Electron doesn't seem to want to load icons from within `asar`s, so this changes
the default icons (used for window and tray) so that they are just regular files
on disk and updates the reference to match.

Part of #9897
jryans added a commit that referenced this issue Jun 18, 2019
@jryans
Update Electron's runtime PNG icon to match others
f3bfb08 
This runtime PNG icon (the default window and tray icon) was not updated to
remove the white background when we last changed the branding. This copies a 265
px PNG from elsewhere to ensure it matches.

Part of #9897
Web App Team automation moved this from In Review to In Test Jun 18, 2019
@jryans
Copy link
Collaborator

jryans commented Jun 18, 2019

Thanks for your patience! This should be fixed in all cases once the next Riot release ships (probably in a few days).

@lampholder lampholder moved this from In Test to Done in Web App Team Jun 19, 2019
@lampholder lampholder moved this from Done to In Test in Web App Team Jun 19, 2019
@jryans
Copy link
Collaborator

jryans commented Jun 19, 2019

This was not included in Riot 1.2.2, so it will go out with the next release.

@jryans jryans mentioned this issue Jun 19, 2019
Closed
@jryans jryans moved this from In Test to Done in Web App Team Jul 8, 2019
@bugger11 bugger11 mentioned this issue Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Electron P2 T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix default Electron window and tray icons element-hq/element-web