Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room previews don't show local echo. #3166

Open
ara4n opened this issue Aug 14, 2024 · 5 comments
Open

Room previews don't show local echo. #3166

ara4n opened this issue Aug 14, 2024 · 5 comments
Assignees
Labels
A-SSS Regression or bug observed when using Simplified Sliding Sync O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Aug 14, 2024

Steps to reproduce

  1. Use SSS, and send a message in a room
  2. Go back to the roomlist
  3. See a stale room preview
  4. A few seconds it updates as the remote echo arrives for the message in question.

Outcome

What did you expect?

Room previews should show local echo, in order for the app to feel fast.

This is effectively a regression of #1294

It's also entangled with #1775

Your phone model

No response

Operating system version

No response

Application version

679

Homeserver

matrix.org

Will you send logs?

No

@ara4n ara4n added the T-Defect label Aug 14, 2024
@ara4n ara4n added the A-SSS Regression or bug observed when using Simplified Sliding Sync label Aug 14, 2024
@Hywan
Copy link
Member

Hywan commented Aug 14, 2024

This isn't related to SSS. It has never worked. The SDK knows the latest event has been updated but the update information isn't propagated to the app. Maybe it can come back with matrix-org/matrix-rust-sdk#3802.

@Hywan Hywan changed the title SSS: room previews don't show local echo. Room previews don't show local echo. Aug 14, 2024
@ara4n ara4n changed the title Room previews don't show local echo. SSS: Room previews don't show local echo. Aug 14, 2024
@ara4n ara4n changed the title SSS: Room previews don't show local echo. Room previews don't show local echo. Aug 14, 2024
@ara4n ara4n removed the A-SSS Regression or bug observed when using Simplified Sliding Sync label Aug 14, 2024
@ara4n
Copy link
Member Author

ara4n commented Aug 14, 2024

huh, i thought you fixed it in #1294?

@Hywan
Copy link
Member

Hywan commented Aug 19, 2024

The app doesn't call Room::latest_event when it's updated. That's the only problem. Let me coordinate with @stefanceriu.

@Velin92 Velin92 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-SSS Regression or bug observed when using Simplified Sliding Sync X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue labels Aug 19, 2024
@Hywan Hywan self-assigned this Aug 19, 2024
@ara4n
Copy link
Member Author

ara4n commented Aug 30, 2024

@stefanceriu it sounds like this is intended to work (and also causes the badge state to lag and the app to feel unresponsive). while not a showstopper it does make the app feel laggy for sure. can we do something?

@stefanceriu
Copy link
Member

@Hywan and I talked about it starting here https://matrix.to/#/!kCCQTCfnABLKGGvQjo:matrix.org/$MfKhgm86vY-yjh8VjrdxI3BvTkMHboN2yzVbKxYxSKc?via=matrix.org&via=element.io&via=one.ems.host

The TL;DR; is that the APIs we have at our disposal at the moment aren't enough to fix this (the RoomListService isn't aware of Timeline changes) and that the EventCache might be the right place to tackle this in as a higher level API. We also need to finall switch to using pure DTOs for passing room list data over to the apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SSS Regression or bug observed when using Simplified Sliding Sync O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Development

No branches or pull requests

4 participants