Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing diff when running as Flatpak #1091

Closed
Marukesu opened this issue Aug 11, 2021 · 4 comments
Closed

Not showing diff when running as Flatpak #1091

Marukesu opened this issue Aug 11, 2021 · 4 comments
Labels
Status: Out of Scope Not solvable within the scope of this code base

Comments

@Marukesu
Copy link
Contributor

What Happened

When running as flatpak, code don't show the diff of the opened file. looking at the terminal output, it seems it is triggering a assertion on ggit_diff_foreach.

Ggit-CRITICAL **: 15:26:01.110: ggit_diff_foreach: assertion 'file_cb != NULL && binary_cb != NULL && hunk_cb != NULL && line_cb != NULL' failed

Expected Behavior

That the diff is shown like in the non-sandboxed version.

Steps to Reproduce

  1. Run code flatpak.
  2. Open a file from a git project.
  3. Modify the file and see that the diff is not shown.

Platform Information

elementaryOS 6.0 Early Access.
code from master branch.

@jeremypw
Copy link
Collaborator

jeremypw commented Dec 8, 2021

Only affects doc gutter - the sidebar shows git status.

@jeremypw
Copy link
Collaborator

jeremypw commented Dec 8, 2021

Looks like (maybe) a git library version issue? Strangely, even if I verify that the line callback is not null immediately before calling the iterator on the diff, I still get this error. This both with a separate function or with a closure used as the callback. So the error seems to be wrong or misleading.

@jeremypw
Copy link
Collaborator

jeremypw commented Dec 8, 2021

As a work around, providing dummy callbacks instead of null for callbacks that are not used seems to work. Pushing a PR.

@jeremypw
Copy link
Collaborator

Closing as due to an upstream bug which is due to be fixed.

@jeremypw jeremypw added the Status: Out of Scope Not solvable within the scope of this code base label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Out of Scope Not solvable within the scope of this code base
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants