Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search only uses color to denote failure #206

Closed
snowparrot opened this issue Aug 30, 2017 · 4 comments · Fixed by #720
Closed

Search only uses color to denote failure #206

snowparrot opened this issue Aug 30, 2017 · 4 comments · Fixed by #720
Labels
Hacktoberfest Used in the month of October for good issues for new contributors Status: Confirmed Verified by someone other than the reporter
Milestone

Comments

@snowparrot
Copy link

snowparrot commented Aug 30, 2017

I have problems seeing red and green. Dark red also looks more like black so e.g.
the search didn't find any item I can't see it on first glance. Other user can be confused, too because there is no other reaction.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@cassidyjames
Copy link
Contributor

Ah we only use color to denote a failed search. We could probably also change the search icon in the entry to something to indicate no matches?

Go go gadget @elementary/ux

@cassidyjames cassidyjames added the Status: Confirmed Verified by someone other than the reporter label Aug 30, 2017
@cassidyjames cassidyjames added this to the juno-beta1 milestone Aug 30, 2017
@cassidyjames cassidyjames changed the title Unsuccessful search is poorly design for people with red–green color blindness Search only uses color to denote failure Aug 30, 2017
@snowparrot
Copy link
Author

@cassidyjames Though a bit unrelated Accessbility should be discussed in HIG so coders are more aware of the problem.

@matzipan
Copy link
Contributor

matzipan commented Aug 30, 2017

@snowparrot perhaps open an issue for the HIG on https://github.com/elementary/website/

The relevant file is here: https://github.com/elementary/website/blob/62b751006961549634e4a0a15d52c5013af130fa/docs/human-interface-guidelines.md

@danirabbit danirabbit modified the milestones: juno-beta1, juno-beta2 Mar 13, 2018
@danirabbit danirabbit removed this from the juno-beta2 milestone May 1, 2018
@cassidyjames cassidyjames added the Hacktoberfest Used in the month of October for good issues for new contributors label Oct 3, 2019
@mi11y
Copy link
Contributor

mi11y commented Oct 27, 2019

Using the search entry's primary_icon_name, I set it to "dialog-error-symbolic" whenever the style class is set to Gtk.STYLE_CLASS_ERROR. I think it works pretty well and feedback is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Used in the month of October for good issues for new contributors Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants