Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

../lib/Widgets/Utils.vala:267:38-267:40: error: Argument 1: Cannot convert from unowned string' to unowned uint8[]' #658

Closed
mcatanzaro opened this issue Sep 8, 2023 · 1 comment · Fixed by #659
Closed

../lib/Widgets/Utils.vala:267:38-267:40: error: Argument 1: Cannot convert from unowned string' to unowned uint8[]' #658

mcatanzaro opened this issue Sep 8, 2023 · 1 comment · Fixed by #659

Comments

@mcatanzaro
Copy link
Contributor

What Happened?

When building Granite git main using org.freedesktop.Sdk.Extension.vala-nightly:

../lib/Widgets/Utils.vala:267:38-267:40: error: Argument 1: Cannot convert from `unowned string' to `unowned uint8[]'
  267 |         css_provider.load_from_data (css);
      |                                      ^~~

Lorenz pointed me to this corresponding vala issue: https://gitlab.gnome.org/GNOME/vala/-/issues/1478

It looks like we need to revert @alice-mkh's previous fix 9065ac6 because the change in vala has been reverted.

Steps to Reproduce

Build

Expected Behavior

Failed to build

OS Version

Other Linux

Software Version

Compiled from git

Log Output

No response

Hardware Info

No response
@lw64
Copy link

lw64 commented Sep 8, 2023

I tested it and it indeed works with the latest valac from main with the commit reverted.

@mcatanzaro mcatanzaro mentioned this issue Sep 9, 2023
Merged
bobby285271 pushed a commit that referenced this issue Sep 9, 2023
@mcatanzaro
Revert "Fix build with newer Vala (#637)" (#659)
b86e04d 
This reverts commit 9065ac6.

Vala has reverted the API break that necessitated this change, and now
we cannot build with newer Vala again.

Fixes #658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Fix build with newer Vala (#637)"
2 participants
@mcatanzaro @lw64