FileTypes: Use fd.o text-x-generic for text
#1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `text` mimetype filename to `text-x-generic` to match FreeDesktop.org Icon Naming Specification. Same change made for the `-rtl` version. Update the symlink names in mimes/meson.build.
newhoa
changed the title
text-x-generic for text
danirabbit
approved these changes
Jan 2, 2023
There was a problem hiding this comment.
Looks good! Happy to make this match the spec and symlink makes sense to me.
I'm not 100% sure if those names are used, but I'd rather include the symlinks and have them unused then remove the symlinks and accidentally break something. A lot of these mime symlinks have been added over the years to fix various bugs. It might be worth going through git blame and seeing if we can add comments to the build file documenting that they're all for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
textmimetype filename totext-x-genericto match FreeDesktop.org Icon Naming Specification. Same change made for the-rtlversion.Update the symlink names in mimes/meson.build.
Let me know if I need to make any other changes outside of the meson.build for symlinks or anything.
Also something I noticed while editing the meson.build file for symlinks, I'm not sure if plain names like
wordprocessingandtextare needed as symlinks anymore (same with stuff likeimageorpackagenames/symlinks). Are these used anywhere that anyone knows of?Thanks.