Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps can set background/text color for Notifications #46

Closed
lainsce opened this issue Jan 13, 2020 · 8 comments
Closed

Apps can set background/text color for Notifications #46

lainsce opened this issue Jan 13, 2020 · 8 comments

Comments

@lainsce
Copy link

lainsce commented Jan 13, 2020

For example, if one changes the Music playing, the album art dictates colours for the Notification in for ex. Android:

May need some modifications in code in apps and the Notification Center, but I think this is a good idea.

@danirabbit danirabbit changed the title Wishlist: Apps can set background/text color for Notifications Apps can set background/text color for Notifications Jan 13, 2020
@cassidyjames
Copy link
Contributor

Hm, on Android it is actually the OS that sets the background and foreground color afaik, because it does this for all media-playback-type notifications using the color palette API. I believe apps may also be able to set some styling, but I'm not sure how that interacts with the system-wide dark style.

@lainsce
Copy link
Author

lainsce commented Jan 13, 2020

I have no way of knowing Android's global dark styling interactions because I have no phones with Android 10. 😞

@danirabbit
Copy link
Member

I'm personally -1 on this. I don't think the results are very good looking and it seems odd to single out music notifications

@lainsce
Copy link
Author

lainsce commented Jan 13, 2020

Music was just an example. Anything that would be sane to have colored notifications would benefit from this.

@lainsce
Copy link
Author

lainsce commented Jan 17, 2020

Another good example is with critical notifications like "Battery is critically low", maybe using our warning colors? 🖌️

@cassidyjames
Copy link
Contributor

@lainsce that's already something we can do with the priority levels set by notifications today, if we wanted. But that seems pretty aggressive.

@danirabbit
Copy link
Member

In master critical notifications have red title text

@lainsce
Copy link
Author

lainsce commented Nov 12, 2020

Looking back on it, this was a dumb idea tbh

@lainsce lainsce closed this as completed Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants