MainWindow: make tabs pinnable #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to fix #29. I actually came to file a similar issue to help me clean up my tab bar when I have a few long-running process, e.g. web servers, and found it was already reported. So far, this draft just makes tabs pinnable but does not prevent changes to the tabs themselves.
Icon-wise, I was looking for a
pinnedicon but foundchanges-preventandview-pin. Neither seem like the perfect fit, but either might work fine. Open to feedback. I am seeing an issue where the icon is not centered in the pinned tab; not sure if I'm doing something wrong, or if this is a bug in Granite or the stylesheet.