This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Show a message when reboot required #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donadigo
suggested changes
Apr 5, 2018
There was a problem hiding this comment.
Before you check for that file, you should probably also check if the monitor event was GLib.FileMonitorEvent.CREATED before doing anything else.
Also since you create a file for /var/run, you can get the reboot-required file by calling GLib.File.resolve_relative_path on it like that:
restart_file = restart_folder.resolve_relative_path ("reboot-required"); (I think). While we're at it you can also cache this file because there is no need to create it everytime there's an event.
|
Hmm, I like the idea, but I'm not sure how I feel about the styling. Something feels kind of crammed in there or unbalanced. |
|
Looks like some work is required on this so converting to draft. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes elementary/quick-settings#40