Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Redesign: Suspend and Shut Down Buttons Style #83

Closed
wants to merge 13 commits into from
Closed

Redesign: Suspend and Shut Down Buttons Style #83

wants to merge 13 commits into from

Conversation

lainsce
Copy link

@lainsce lainsce commented Jul 16, 2019

As per the redesign mockup in:
session-indicator-popover_redesign

I've styled the shut down and suspend buttons as close as possible.
Looks like:
Screenshot from 2019-07-16 12 26 33

This is Part 1 of ??? of the Redesign PRs.

@lainsce
Copy link
Author

lainsce commented Jul 16, 2019

This PR is open for reviews now.

@danirabbit
Copy link
Member

I'm not sure this is an improvement. Now users have to scan both horizontally and vertically to see all of the available options

@lainsce
Copy link
Author

lainsce commented Jul 16, 2019

The universal icons should help with fast scanning. They're faster to target as well.

@danirabbit
Copy link
Member

@elementary/ux

Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in the same boat as @danrabbit that I'm unsure if this is easier to scan and use or not with the two actions. If we were wanting to have three or four it might be a better layout, but I'm not really convinced right now.

Also, see inline comments for some small stuff. 😄

data/system-suspend-symbolic.svg Show resolved Hide resolved
src/Indicator.vala Outdated Show resolved Hide resolved
src/Indicator.vala Outdated Show resolved Hide resolved
@danirabbit
Copy link
Member

Something else to consider is if we're still interested in doing something like #45 this design conflicts with our ability to have secondary text here

@lainsce
Copy link
Author

lainsce commented Jul 17, 2019

We could still have the secondary text, and a selection class done on the shutdown button.
See (rough mockup):
restart-required_redesign

@lainsce
Copy link
Author

lainsce commented Nov 1, 2019

Closing because the redesign doesn't offer any improvement other than "looks good" which is subjective. It also interferes with new developments.

@lainsce lainsce closed this Nov 1, 2019
@lainsce lainsce deleted the suspend-shutdown-buttons branch November 1, 2019 04:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants