-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is BOLFI robust to scaling of the parameters? #292
Comments
I'm not an expert in GPs, but I think you should use a different kernel. The default kernel has just one length scale for all parameters. So for example something like:
I hope this helps you in the right direction. Also, please update ELFI to the newest version 0.7.3. :) |
I suppose very different scales can be problematic for NUTS as well, and we have considered implementing some kind of normalizing. You could also try the basic Metropolis sampler, which allows (requires, actually) manually setting the "scale" of each parameter. Have you considered trying the opposite in your case: having roughly equal parameter scales and then upscaling in the simulator? |
Yeah, I already did a normalization/rescaling in my simulator and it seems to work. |
Summary:
Running BOLFI on the example MA2 with one scaled parameter is not giving meaningful results.
Description:
If I run the BOLFI fitting algorithm on the toy example MA2 where one parameter is scaled by the factor 10**4 for sampling and rescaled in the MA2 function the fitting breaks down. The acquisition function is not meaningful and also after running NUTS the posterior is not what it should look like.
If I am right, the fitting of the posterior should be independent of the order of magnitude of the parameters and all parameters in the GP should scale with the order. Is this correct?
I ran in this issue while trying to fit a more complex model.
Reproducible Steps:
Current Output:
The acquisition function is screwed:
and also the marginals are uninformative:
Expected Output:
I expected a similar shape of the functions as for the unscaled model.
ELFI Version: 0.7
Python Version: 3.5
Operating System:
The text was updated successfully, but these errors were encountered: