Ability to edit symlink destination

[alexandrustinov]

The Midnight Commander has pretty nice feature File->Edit symlink , once you select the symlink you can change the destination that way

For far2l there are F4 or Ctrl+A keystrokes, Attributes dialog shows destination link path but input box is disabled (read/only).
I can change practically any attribute there but not the symlink destination path.

Is it possible to allow to change the symlinks destination by the Attributes dialog box?

[akruphi]

@elfmz After 65e1870 change symlink has strange behavior:

1. if I change field Symlink and press Enter on any field in dialog the symlink has not changed without any Errors
2. if I change field Symlink and click on { Set } or press Enter only in button { Set } the symlink has changed and give error in any case because after the line

   far2l/far2l/src/setattr.cpp

   Line 1131 in 13c0919

   int r = sdc_symlink(DlgParam.SymLink.GetMB().c_str(), strSelName.GetMB().c_str());

   check if (r !=0) was lost and now Message with Msg::SetAttrSymlinkFailed must be always shown.

But I cann't explain situation 1.

[alexandrustinov]

The issue has not been perfectly completed yet :)
Shortcut Ctrl+A works fine.
Shortcut F4 over good symlinks to folders shows the "Attributes" dialog, that way is possible to redirect the symlink as well, that's nice too.

But If I'm trying to "edit" broken symlink using the F4 shortcut (symlink which points to non-existent file/folder) - far2l shows me red message box with text "No such file or directory (2) Cannot open the file" and nothing else happens further.

That's a bit unexpected, because the main goal there - is to be able to fix broken symlink in place.

From other hand the Ctrl+A works fine with the broken symlinks, as I said before.

[akruphi]

@alexandrustinov This is the common F4 behavior: on file try open it for edit; on directory show attribute dialog.

Additional in #1744 I add confirmation for case when new symlink target not exist.
Now confirmation texts are draft. Please give response and/or may be advice about more clearer variants of text in messagebox.