Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: parsing error on words containing non English characters #74

Closed
henriklovhaug opened this issue Apr 11, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@henriklovhaug
Copy link

If I try to write a name of something containing non English characters, harper-ls tries to spellcheck the substring after the special character. I don't expect it to recognise names from other languages since it's meant for English, but it hinders me from adding the whole word to the global/local dictionary using my editor's quick fix.

Example:
I try to write the word Løvetann. harper-ls asks if I ment to spell vetann this way, and the quick fix option is to add vetann to the dictionary.

Requested behaviour:
I would like harper-ls to mark the whole word, and give me the option to add Løvetann to the global/local dictionary.

@elijah-potter
Copy link
Owner

Thank you for bringing this to my attention. I'll try to get a fix available as soon as possible.

@elijah-potter elijah-potter self-assigned this Apr 11, 2024
@elijah-potter elijah-potter added the bug Something isn't working label Apr 11, 2024
@lukasmwerner
Copy link
Collaborator

Just encountered this as well. Here an example case

## Naïve Algorithm

harper offers to change the ve part of the word.

@elijah-potter
Copy link
Owner

I've included some non-English characters into words in the latest Git commits, but not all (not CJK, for example). Hopefully this resolves issues with the kinds of words y'all have mentioned without unnecessarily linting intentionally non-English text.

Let me know if this crops up again (after the next version of harper-ls is release and you've updated). For now, I'm going to close the issue.

Thank you for bringing this to my attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants