Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some colour mismatch in Ant-Dracula gnome-shell theme #24

Closed
milouse opened this issue Oct 23, 2017 · 9 comments
Closed

Some colour mismatch in Ant-Dracula gnome-shell theme #24

milouse opened this issue Oct 23, 2017 · 9 comments

Comments

@milouse
Copy link

milouse commented Oct 23, 2017

Hi!

I don't know if it's on purpose or not, but I found some ant-bloody colors in the ant-dracula theme, mainly in the user menu and actions, as shown in the following captures:

dracula_usermenu
dracula_sessionquit
dracula_shutdown

Some label and progress bar use the bloody red colour, when dracula pink may have had the same impact. What do you think about it?

For the two dialog it's not big deal, but it's really annoying (IMHO) for the user submenu and the two progress bar.

[edit] typo

@milouse
Copy link
Author

milouse commented Oct 23, 2017

BTW, thank you very much for your work, especially with the drucula theme. As I really love pink, It's a pleasure to have a nicely craft dark/pink theme!

@EliverLara
Copy link
Owner

Thank you very much for the observation, I completely forget it.

@milouse
Copy link
Author

milouse commented Oct 24, 2017

No problem :)

@EliverLara
Copy link
Owner

Fixed in latest version.

@milouse
Copy link
Author

milouse commented Oct 30, 2017

The problem still exists in the dracula shell theme with the last version, as seen on my previous captures :s (Gnome 3.26 on Archlinux)

@EliverLara
Copy link
Owner

The issue was with the Ant-Bloody variant since it was taking the colors of the Ant-Dracula theme, so the Att-Dracula colors did not change.

@milouse
Copy link
Author

milouse commented Oct 31, 2017

The red progress bar are intended in the Ant-Dracula theme ? Just to be sure.

@EliverLara
Copy link
Owner

Yes, it was made to match the gtk theme, Do you think it should be accent color (pink)?

@milouse
Copy link
Author

milouse commented Nov 3, 2017

For the logout and shutdown modal, I could understand it uses red color to alert the user on the consequences of these actions. However for the simple progress bar, yes I think the accent color (pink) would be a better choice. I've quickly change the color in the compiled file to show you the difference. I find it more logical, regarding the pink underline effect on the menu button

screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants